Asynchronous method validations

[fayimora]

Currently, @MethodValidation requires the method to return ValidationResult. Would it be possible to also support returning Future[ValidationResult]? Recently, I've had situations where my validation check returns a Future so I have to do something like:

myFut.map(truth => Validation.validate(truth, "Oops!"))

but that returns a Future[ValidationResult]

[cacoco]

The original intent of @MethodValidation is not for performing remote calls to do validation but more to provide validation on the parsed JSON request body.

Generally, the thinking is if you need to do a validation that requires an asynchronous call it would not be through this part of the framework. It is an interesting idea however to have something akin to this but I'm not sure it would be the current @MethodValidation.

Thanks,
-c

[fayimora]

@cacoco ok thanks 👍

I currently use @MethodValidation to validate data too. For instance, if I make a POST request to /api/users and I need to tell the client the username has been taken, I do the check in @MethodValidation. Does that mean I shouldn't be doing that?

[cacoco]

@fayimora it doesn't mean you can't or shouldn't do it that way. It just means we didn't design the current implementation of @MethodValidation for that use case. It's meant to be basic validation on the structure and values of the data coming in. We typically perform the remote calls as a second pass in validation after this layer.

Like I mentioned, it's an interesting idea but we probably wouldn't tie it to @MethodValidation in it's current form because@MethodValidation is highly integrated to JSON parsing right now.