New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make mustache factory use baseTemplatePath local_docroot and template_path #56

Closed
yuzeh opened this Issue Jul 29, 2013 · 2 comments

Comments

2 participants
@yuzeh
Contributor

yuzeh commented Jul 29, 2013

I have a couple of mustache files stored in resources/mustache. I have set -Dlocal_docroot=resources and -Dtemplate_path=mustache/ when running my finatra server.

Whenever I load a partial (which is in the resources/mustache directory) i need to prefix the partial name with mustache/ in the file that loads the partial. I'd expect to be able to do

{{> my_partial.mustache}}

instead of having to do

{{> mustache/my_partial.mustache}}

Is this expected behavior, or is there a bug on my end? Should this be changed? If so I can come up with a patch.

@capotej

This comment has been minimized.

Contributor

capotej commented Jul 31, 2013

Nice find! It makes sense that partial paths would go off template_path instead of local_docroot. I'd happily accept a patch or I can do it for next release.

@yuzeh

This comment has been minimized.

Contributor

yuzeh commented Aug 1, 2013

I'll write a patch this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment