request.routeParams should be decoded

[salomvary]

When requesting /hello%3Aworld?bar=hello%3Aworld

get("/:foo") { request =>
    request.routeParams.get("foo").get should equal("hello:world") // it's actually `hello%3Aworld`
    request.params.get("bar").get should equal("hello:world")
}

Workaround:

import org.jboss.netty.handler.codec.http.QueryStringDecoder
import org.jboss.netty.util.CharsetUtil

QueryStringDecoder.decodeComponent(param, CharsetUtil.UTF_8)

[pcalcado]

It seems like we are neither using Finagle's RequestParamMap nor replicating its logic for route params.

RequestParamMap seems a bit hard to extend properly, but I imagine that it would be good not to repeat the logic here. I am also not a big fan of router adding things to the request and having to care about this kind of encoding and etc.

I think I can get a fix for this...

[turbolent]

It seems like when using a case class instead of Request and annotating a field with @RouteParam, it is still not properly decoded.

[cacoco]

@turbolent this issue was filed against 1.x which is not relevant to 2.x. If you have an issue can you file a new one? Thanks.