maven => sbt

[mosesn]

sbt is the de facto build tool in scala-land, finatra should probably use it.

[capotej]

Happening here: https://github.com/twitter/finatra/tree/sbt

[mosesn]

Preliminary feedback:

2.10.3 maybe instead of 2.10.0?

Scalatest finally made the jump to 2.0, so you can get on a stable version of 2.0 scalatest if you want.

You should specify your organization in your build.sbt

I think finagle-core already pulls in its own version of guava. It might be safer to just rely on that rather than ending up with possibly mismatched guava versions.

Maybe add a build.properties file to standardize your sbt?

[capotej]

Awesome, this is great feedback for an sbt noob like me:

1. 2.10.3: I'll try this but I was under the impression this would end up fetching twitter-server_2.10.3 when using the %% notation

2. Scalatest 2 doesn't support scala 2.9, its only built for 2.10, hence why we went back to 1.x

3. Did this already, haven't pushed it up I think

4. guava: Good idea

5. build properties: I'll look into this

[mosesn]

1. Nope, 2.10.x is all ABI compatible, so it doesn't matter which version. The name that twitter-server is published under is twitter-server_2.10.

2. 💢

3. 💃

4. 👵

5. 👴

[capotej]

db4019a