Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maven => sbt #78

Closed
mosesn opened this issue Dec 9, 2013 · 5 comments
Closed

maven => sbt #78

mosesn opened this issue Dec 9, 2013 · 5 comments
Milestone

Comments

@mosesn
Copy link
Contributor

@mosesn mosesn commented Dec 9, 2013

sbt is the de facto build tool in scala-land, finatra should probably use it.

@capotej
Copy link
Contributor

@capotej capotej commented Jan 2, 2014

@mosesn
Copy link
Contributor Author

@mosesn mosesn commented Jan 2, 2014

Preliminary feedback:

2.10.3 maybe instead of 2.10.0?

Scalatest finally made the jump to 2.0, so you can get on a stable version of 2.0 scalatest if you want.

You should specify your organization in your build.sbt

I think finagle-core already pulls in its own version of guava. It might be safer to just rely on that rather than ending up with possibly mismatched guava versions.

Maybe add a build.properties file to standardize your sbt?

@capotej
Copy link
Contributor

@capotej capotej commented Jan 2, 2014

Awesome, this is great feedback for an sbt noob like me:

  1. 2.10.3: I'll try this but I was under the impression this would end up fetching twitter-server_2.10.3 when using the %% notation

  2. Scalatest 2 doesn't support scala 2.9, its only built for 2.10, hence why we went back to 1.x

  3. Did this already, haven't pushed it up I think

  4. guava: Good idea

  5. build properties: I'll look into this

@mosesn
Copy link
Contributor Author

@mosesn mosesn commented Jan 3, 2014

  1. Nope, 2.10.x is all ABI compatible, so it doesn't matter which version. The name that twitter-server is published under is twitter-server_2.10.

  2. 💢

  3. 💃

  4. 👵

  5. 👴

@capotej
Copy link
Contributor

@capotej capotej commented Jan 4, 2014

@capotej capotej closed this Jan 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants