/finatra

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Response tied to originating request #86

Closed
capotej opened this Issue Jan 7, 2014 · 1 comment

Comments

Assignees
No one assigned
Labels
None yet
Milestone
  1.5.1
2 participants
@capotej @leifwickland
@capotej
Contributor

capotej commented Jan 7, 2014

Right now, responses are composed independently from the request, making it problematic to build features like CSRF or sessions. We should be using request.response to build our responses, but some refactoring is needed, as the response builder doesn't know about request.

@capotej capotej closed this in 83fa4f8 Jan 9, 2014

@leifwickland

This comment has been minimized.

Sign in to view

leifwickland commented Apr 2, 2014

The Finatra.info Documentation for Response links to the old Response.scala, which no longer exists as a consequence of this change. The dead link is at the end of the section in the sentence "See the Response class for more details."

I'm sorry if this isn't the best place to report that problem.

cacoco pushed a commit that referenced this issue May 13, 2015

@capotej
Response is now tied to originating Request, fixes #86 
Previously, responses were generated independently of requests; This made it difficult to modify
the response out-of-band (like inside the framework on the users behalf, or in a filter). Now, you
can use `request.response` to access the response from any context in the framework or filter. See
`RequestResponseSpec` for details.

This change also renames Response to ResponseBuilder, which better describes the purpose of
this class.
4a4a4dd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment