/finatra

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix template file resolving for packaged jarfiles #1

Merged
merged 1 commit into from Jul 2, 2012

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@franklinhu @capotej
@franklinhu

franklinhu commented Jul 2, 2012

Using new File(...) doesn't work to resolve the template files inside packaged jars.
Since finatra already has a twitter/util dependency through finagle, used TempFile to solve this problem.

Also bumped the pom.xml to a snapshot version so local development doesn't clobber artifacts

@capotej capotej closed this Jul 2, 2012

@capotej capotej reopened this Jul 2, 2012

capotej added a commit that referenced this pull request Jul 2, 2012

@capotej
Merge pull request #1 from franklinhu/templatefiles 
Fix template file resolving for packaged jarfiles
40ca302

@capotej capotej merged commit 40ca302 into twitter:master Jul 2, 2012

scosenza added a commit that referenced this pull request Aug 11, 2015

@scosenza jenkins
finatra-http: Prevent regexes in string routes and optimize route mat… 
…ching for performance parity with raw Finagle HTTP

Problem

Finatra currently allows user specified regular-expressions in routes which can cause confusion when combined with the frameworks use of regular expressions to extract route params. In addition, certain route matching optimizations are difficult when arbitrary regular expressions can be used.

Solution

Prevent user specified regexes in string based routes and optimize route matching for performance parity with raw Finagle HTTP.

Result

Finagle HTTP Benchmark Results
~$ weighttp -n 500000 -c 40 -t 1 -k http://localhost:8888/hi
spawning thread #1: 40 concurrent requests, 500000 total requests
finished in 11 sec, 349 millisec and 373 microsec, 44055 req/s, 2237 kbyte/s
requests: 500000 total, 500000 started, 500000 done, 500000 succeeded, 0 failed, 0 errored

Finatra Benchmark Results
~$ weighttp -n 500000 -c 40 -t 1 -k http://localhost:8888/hi
spawning thread #1: 40 concurrent requests, 500000 total requests
finished in 11 sec, 336 millisec and 373 microsec, 44105 req/s, 2239 kbyte/s
requests: 500000 total, 500000 started, 500000 done, 500000 succeeded, 0 failed, 0 errored

RB_ID=710685
c505fa2

cacoco pushed a commit that referenced this pull request Sep 7, 2016

Ameya Naik
Merge pull request #1 from ameyanaik11/ameyanaik11-patch-markdown 
Updated user-guide/getting-started markdown
9b707a9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment