Fix template file resolving for packaged jarfiles #1
Conversation
capotej
added a commit
that referenced
this pull request
Jul 2, 2012
Fix template file resolving for packaged jarfiles
scosenza
added a commit
that referenced
this pull request
Aug 11, 2015
…ching for performance parity with raw Finagle HTTP Problem Finatra currently allows user specified regular-expressions in routes which can cause confusion when combined with the frameworks use of regular expressions to extract route params. In addition, certain route matching optimizations are difficult when arbitrary regular expressions can be used. Solution Prevent user specified regexes in string based routes and optimize route matching for performance parity with raw Finagle HTTP. Result Finagle HTTP Benchmark Results ~$ weighttp -n 500000 -c 40 -t 1 -k http://localhost:8888/hi spawning thread #1: 40 concurrent requests, 500000 total requests finished in 11 sec, 349 millisec and 373 microsec, 44055 req/s, 2237 kbyte/s requests: 500000 total, 500000 started, 500000 done, 500000 succeeded, 0 failed, 0 errored Finatra Benchmark Results ~$ weighttp -n 500000 -c 40 -t 1 -k http://localhost:8888/hi spawning thread #1: 40 concurrent requests, 500000 total requests finished in 11 sec, 336 millisec and 373 microsec, 44105 req/s, 2239 kbyte/s requests: 500000 total, 500000 started, 500000 done, 500000 succeeded, 0 failed, 0 errored RB_ID=710685
cacoco
pushed a commit
that referenced
this pull request
Sep 7, 2016
Updated user-guide/getting-started markdown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Using
new File(...)doesn't work to resolve the template files inside packaged jars.Since finatra already has a twitter/util dependency through finagle, used
TempFileto solve this problem.Also bumped the pom.xml to a snapshot version so local development doesn't clobber artifacts