Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helper for setting contentType #115

Merged
merged 1 commit into from Feb 18, 2014

Conversation

@mmurray
Copy link
Contributor

commented Feb 16, 2014

The docs indicate that this is how you should set contentType:

render.body("custom response").contentType("application/mine").toFuture

I think the helper in this pull request is necessary to make that syntax possible, because without it I get the following error:

Option[String] does not take parameters

@twoism

This comment has been minimized.

Copy link
Contributor

commented Feb 18, 2014

LGTM! Looks like this was caused by the netty upgrade that changed header access. thanks!

twoism added a commit that referenced this pull request Feb 18, 2014

Merge pull request #115 from murz/content-type-helper
Add helper for setting contentType

@twoism twoism merged commit e5b579c into twitter:master Feb 18, 2014

1 check passed

default The Travis CI build passed
Details

@mmurray mmurray deleted the mmurray:content-type-helper branch Feb 22, 2014

cacoco pushed a commit that referenced this pull request May 13, 2015

Merge pull request #115 from murz/content-type-helper
Add helper for setting contentType

cacoco pushed a commit that referenced this pull request May 14, 2015

Merge pull request #115 from murz/content-type-helper
Add helper for setting contentType
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.