New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bytes length for content-length instead of string length #117

Merged
merged 1 commit into from Feb 18, 2014

Conversation

2 participants
@davydkov
Contributor

davydkov commented Feb 18, 2014

When response text contains for example cyrillic letters - then the content-length of response is not the same as length of string, so we should use length of byte array.

Also I noticed that there is contentType field in View class, but it is not used.

@twoism

This comment has been minimized.

Contributor

twoism commented Feb 18, 2014

nice, thanks!

twoism added a commit that referenced this pull request Feb 18, 2014

Merge pull request #117 from beenokle/master
Use bytes length for content-length instead of string length

@twoism twoism merged commit 5615a67 into twitter:master Feb 18, 2014

1 check passed

default The Travis CI build passed
Details

@zhanggl zhanggl referenced this pull request Feb 25, 2014

Closed

Response body truncated #120

cacoco pushed a commit that referenced this pull request May 13, 2015

Merge pull request #117 from beenokle/master
Use bytes length for content-length instead of string length

cacoco pushed a commit that referenced this pull request May 14, 2015

Merge pull request #117 from beenokle/master
Use bytes length for content-length instead of string length
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment