Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maxRequestSize flag has no effect #127

Merged
merged 1 commit into from Mar 24, 2014
Merged

maxRequestSize flag has no effect #127

merged 1 commit into from Mar 24, 2014

Conversation

@manjuraj
Copy link
Contributor

@manjuraj manjuraj commented Mar 22, 2014

maxRequestSize flag has no effect because codec gets initialized when FinatraServer object is loaded and hence uses only the default value of 5MB - fix is to make codec lazy val

… FinatraServer object is loaded and hence uses only the default value of 5MB - fix is to make codec lazy val
@twoism
Copy link
Contributor

@twoism twoism commented Mar 24, 2014

good catch! thanks!

twoism added a commit that referenced this pull request Mar 24, 2014
maxRequestSize flag has no effect
@twoism twoism merged commit 847bb22 into twitter:master Mar 24, 2014
1 check passed
1 check passed
default The Travis CI build passed
Details
cacoco pushed a commit that referenced this pull request May 13, 2015
maxRequestSize flag has no effect
cacoco pushed a commit that referenced this pull request May 14, 2015
maxRequestSize flag has no effect
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants