Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mixing Router with Twitter App creates exitTimer thread per request #135

Merged
merged 1 commit into from May 16, 2014

Conversation

@manjuraj
Copy link
Contributor

commented Apr 23, 2014

mixing Router with Twitter App creates exitTimer thread per request

See: https://github.com/twitter/util/blob/master/util-app/src/main/scala/com/twitter/app/App.scala#L63

I also think def route should be val route

@manjuraj

This comment has been minimized.

Copy link
Contributor Author

commented May 16, 2014

following up on this

capotej added a commit that referenced this pull request May 16, 2014

Merge pull request #135 from manjuraj/master
mixing Router with Twitter App creates exitTimer thread per request

@capotej capotej merged commit 778b58e into twitter:master May 16, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@capotej

This comment has been minimized.

Copy link
Contributor

commented May 16, 2014

Oops! Nice work :)

cacoco pushed a commit that referenced this pull request May 13, 2015

Merge pull request #135 from manjuraj/master
mixing Router with Twitter App creates exitTimer thread per request

cacoco pushed a commit that referenced this pull request May 14, 2015

Merge pull request #135 from manjuraj/master
mixing Router with Twitter App creates exitTimer thread per request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.