Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More render shortcuts #139

Merged
merged 1 commit into from May 8, 2014
Merged

More render shortcuts #139

merged 1 commit into from May 8, 2014

Conversation

@grandbora
Copy link
Contributor

@grandbora grandbora commented May 8, 2014

Adds created and accepted

grandbora
capotej added a commit that referenced this pull request May 8, 2014
More render shortcuts
@capotej capotej merged commit 5f4be0d into twitter:master May 8, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@grandbora grandbora deleted the grandbora:render-shortcuts branch May 8, 2014
@twoism
Copy link
Contributor

@twoism twoism commented May 9, 2014

Feel like adding accessDenied while you're at it? I can't think of any more common responses ATM.

@twoism
Copy link
Contributor

@twoism twoism commented May 9, 2014

oh, guess this was already merged. next time then.

@grandbora
Copy link
Contributor Author

@grandbora grandbora commented May 9, 2014

Sure I can add just another one, but which status did you mean with access denied. We defined 401-unauthorized and 403- forbidden already.

@twoism
Copy link
Contributor

@twoism twoism commented May 9, 2014

oh yeah, both would be awesome.

On Thu, May 8, 2014 at 5:15 PM, Bora Tunca notifications@github.com wrote:

Sure I can add it just another one, but which status did you mean with access
denied. We defined 401-unauthorized and 403- forbidden already.


Reply to this email directly or view it on GitHubhttps://github.com//pull/139#issuecomment-42621654
.

@twoism
Copy link
Contributor

@twoism twoism commented May 9, 2014

LGTM!

On Thu, May 8, 2014 at 5:19 PM, Bora Tunca notifications@github.com wrote:

here already :)

https://github.com/grandbora/finatra/blob/0a23960aa658dd45e0e84a15a8b0a680e2db5838/src/main/scala/com/twitter/finatra/ResponseBuilder.scala#L238-L239


Reply to this email directly or view it on GitHubhttps://github.com//pull/139#issuecomment-42621833
.

cacoco pushed a commit that referenced this pull request May 13, 2015
cacoco pushed a commit that referenced this pull request May 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants