New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HttpServerDispatcher to fix remoteAddress property of Request. #142

Merged
merged 1 commit into from Oct 15, 2014

Conversation

2 participants
@pixell
Contributor

pixell commented May 15, 2014

Hi,

I wrote to finatra-users about the issue I had with hardcoded remoteAddress-property of Request. Today I had time to investigate and while browsing code for both Finatra and Finagle I noticed that just by changing FinatraServer to use HttpServerDispatcher instead of SerialServerDispatcher the property works.

Having just started with Finatra and Finagle, I decided to send this pull request to get some feedback if the change is ok.

capotej added a commit that referenced this pull request Oct 15, 2014

Merge pull request #142 from pixell/remoteaddress-fix
Use HttpServerDispatcher to fix remoteAddress property of Request.

@capotej capotej merged commit c3197f8 into twitter:master Oct 15, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@capotej

This comment has been minimized.

Contributor

capotej commented Oct 15, 2014

Nice work!

cacoco pushed a commit that referenced this pull request May 13, 2015

Merge pull request #142 from pixell/remoteaddress-fix
Use HttpServerDispatcher to fix remoteAddress property of Request.

cacoco pushed a commit that referenced this pull request May 14, 2015

Merge pull request #142 from pixell/remoteaddress-fix
Use HttpServerDispatcher to fix remoteAddress property of Request.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment