Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not log errors in the ErrorHandler #163

Merged
merged 1 commit into from Jan 7, 2015

Conversation

@eponvert
Copy link
Contributor

@eponvert eponvert commented Sep 12, 2014

This change is to suppress excessive logging for exceptions that are captured and handled correctly downstream. Specifically, we're following the conventions suggested in the documentation by using an error handler to respond to certain requests a 404 NOT FOUND. Because of the log.error() in this method, a full stacktrace is printed to the logs with the message "Internal Server Error" even though it's not really an internal error.

@gianluca-sabena
Copy link

@gianluca-sabena gianluca-sabena commented Nov 7, 2014

+1

1 similar comment
@jfrazee
Copy link

@jfrazee jfrazee commented Nov 19, 2014

+1

capotej added a commit that referenced this pull request Jan 7, 2015
Do not log errors in the ErrorHandler
@capotej capotej merged commit fcce166 into twitter:master Jan 7, 2015
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
cacoco pushed a commit that referenced this pull request May 13, 2015
Do not log errors in the ErrorHandler
cacoco pushed a commit that referenced this pull request May 14, 2015
Do not log errors in the ErrorHandler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants