Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dependency on scalatest #179

Merged
merged 1 commit into from Jan 7, 2015

Conversation

@c089
Copy link
Contributor

@c089 c089 commented Nov 17, 2014

currently, finatra will pull in scalatest in an outdated version, which
will cause version conflicts with upstream projects that want to use
newer versions. the only reason for this seems to be the FlatSpecHelper,
which is a one-liner only mixing in the Helper trait. Pull request #59
was already supposed to "Let people choose their test framework" but
didn't go all the way.

this limits the scalatest dependency to the test scope and removes the
FlatSpecHelper from the .jar, so it should be considered a breaking
change. I can provide an accompanying pull request to update the
documentation in capotej/finatra-site, but want to see if the maintainers
agree with this change first

capotej added a commit that referenced this pull request Jan 7, 2015
remove dependency on scalatest
@capotej capotej merged commit 982703a into twitter:master Jan 7, 2015
1 check passed
1 check passed
@caniszczyk
continuous-integration/travis-ci The Travis CI build passed
Details
@c089 c089 deleted the c089:remove-scalatest-dependency branch Jan 8, 2015
@c089 c089 mentioned this pull request Jan 8, 2015
5 of 11 tasks complete
cacoco pushed a commit that referenced this pull request May 13, 2015
cacoco pushed a commit that referenced this pull request May 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants