New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix heroku deployments for template project #181

Merged
merged 7 commits into from Jan 7, 2015

Conversation

2 participants
@tomjadams
Contributor

tomjadams commented Nov 24, 2014

As per issue #180

The included deployment (well, the assembly plugin) does not work against heroku. In short, heroku expects to call stage and the shipped plugin uses assembly:

I made a few changes to get it working:

  1. Added the native packager plugin to project/plugins.sbt

    addSbtPlugin("com.typesafe.sbt" % "sbt-native-packager" % "0.8.0-RC1")
    
  2. Removed the assembly_plugin.sbt file.

  3. Added the necessary references to build.sbt

    import NativePackagerKeys._
    packageArchetype.java_application
    
  4. Changed procfile as follows:

    web: target/universal/stage/bin/<appname> -Dcom.twitter.finatra.config.env=$ENV -Dcom.twitter.finatra.config.adminPort=$ADMIN_PORT -Dcom.twitter.finatra.config.port=:$PORT
    

Notes.

  1. I added the $ADMIN_PORT environment variable so I can run formate start on the local command line to have the app boot via the Procfile.

  2. I added $ENV for the same reason, so that the development or whatever environment can be passed locally while still using the production style startup process.

  3. These require a .env file with those parameters defined as follows:

    PORT=7070
    ADMIN_PORT=:9990
    ENV=development
    

capotej added a commit that referenced this pull request Jan 7, 2015

Merge pull request #181 from tomjadams/tom/heroku_deploy_fix
Fix heroku deployments for template project

@capotej capotej merged commit 129184a into twitter:master Jan 7, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

n3integration added a commit to n3integration/IPLookup that referenced this pull request Mar 13, 2015

cacoco pushed a commit that referenced this pull request May 13, 2015

Merge pull request #181 from tomjadams/tom/heroku_deploy_fix
Fix heroku deployments for template project

cacoco pushed a commit that referenced this pull request May 14, 2015

Merge pull request #181 from tomjadams/tom/heroku_deploy_fix
Fix heroku deployments for template project
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment