Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Controller method callback timing #21

Merged
merged 2 commits into from Aug 18, 2012
Merged

Conversation

@franklinhu
Copy link

@franklinhu franklinhu commented Aug 17, 2012

Add timing of each method call in Controller so there's better observability

@travisbot
Copy link

@travisbot travisbot commented Aug 17, 2012

This pull request passes (merged 3fbdb21 into 3793f79).

@franklinhu
Copy link
Author

@franklinhu franklinhu commented Aug 17, 2012

A small concern is that for paths like / the metric will be Controller/GET//, but I'm unsure if there's a clean way to fixing that. We could prepend Root to each string that starts with / so it turns into Controller/GET/Root/

@travisbot
Copy link

@travisbot travisbot commented Aug 17, 2012

This pull request passes (merged c5d1122 into 3793f79).

capotej added a commit that referenced this pull request Aug 18, 2012
Add Controller method callback timing
@capotej capotej merged commit 113a115 into twitter:master Aug 18, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants