New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Travis CI to build with java8 fix. #244

Merged
merged 41 commits into from Sep 12, 2015

Conversation

3 participants
@cacoco
Member

cacoco commented Sep 11, 2015

No description provided.

scosenza and others added some commits Sep 3, 2015

finatra-jackson: Improve @RequestInject so that generic types can be …
…injected

Problem
FieldInjection currently uses raw types when creating the Guice TypeLiteral

Solution
Create a Guice TypeLiteral that accounts for the full Jackson read JavaType

RB_ID=737880
finatra-http: Assert unique route paths on server startup
Problem
Finatra currently allows multiple routes with the same path

Solution
Assert that paths are unique at server startup

RB_ID=737886
inject-core: Allow TwitterModule.install to be used for non-TwitterMo…
…dules

Problem
TwitterModule.install is currently not supported. This prevents module composition with non-Twitter modules whose construction requires the results of parsed flags (e.g. install(TypesafeConfigModule.fromConfig(createConfigFromFlagValue())))

Solution
Allow TwitterModule.install to be used for non-TwitterModules.

RB_ID=739582
utils: Add is2xxResponse method to identify 2XX responses
Problem
There is currently no way to quickly tell if a response is a 2XX response

Solution
Implement a helper in ResponseUtils to quickly identify a 2XX response

Resolution
Users will be able to quickly tell if a response is a 2XX response

RB_ID=739909
http: Break out the V1 Migration guide into a separate document
Problem
There is some confusion when people search the README and encounter sections in the "migration guide"
which are far from the header and aren't obviously about migration from previous functionality

Resolution
Break out the migration guide into a separate document

Result
It should be more obvious to what the document text is referring.

RB_ID=740238
Update .travis.yml
Updated memory settings.
Update build.sbt
Remove scala compiler exclude and added scala-deps dependency.
Update build.sbt
Unrevert changes.
Update .travis.yml
Add sbt args to increase Xss.
Update .travis.yml
Update max perm size.
finatra/examples - Simplify example directory naming and update READM…
…E.md files

Problem
The naming of the some of the example projects included a superfluous "finatra" prefix that wasn't consistently maintained in newer examples.

Resolution
Remove the "finatra" prefix in example projects.

Result
Less characters.

RB_ID=740987

cacoco added some commits Sep 11, 2015

@cacoco cacoco force-pushed the master branch from 5bd8dc9 to f3926d4 Sep 11, 2015

@codecov-io

This comment has been minimized.

codecov-io commented Sep 12, 2015

Current coverage is 93.67%

Merging #244 into master will not affect coverage as of 1419371

@@            master    #244   diff @@
======================================
  Files          174     174       
  Stmts         2276    2276       
  Branches       272     272       
  Methods          0       0       
======================================
  Hit           2132    2132       
  Partial          0       0       
  Missed         144     144       

Review entire Coverage Diff as of 1419371

Powered by Codecov. Updated on successful CI builds.

cacoco added a commit that referenced this pull request Sep 12, 2015

@cacoco cacoco merged commit 8cf2d26 into master Sep 12, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@cacoco cacoco deleted the ccoco-travis-fixes branch Sep 12, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment