Fix synchronization/correctness issues #3
Merged
+60
−70
Conversation
capotej
added a commit
that referenced
this pull request
Jul 9, 2012
Fix synchronization/correctness issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Using a singleton
FinatraResponse
object has a variety of issues:resp
allows data to persist across requests if those fields aren't overridden such as:FinatraResponse
for each request