New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sbt-revolver to the hello-world example #324

Closed
wants to merge 1 commit into
base: master
from

Conversation

3 participants
@fayimora
Contributor

fayimora commented May 20, 2016

Fixes #209
Closes #273

Problem

The documentation does not mention anything about reloading the server when
changes are made. There have also been issues created requesting this feature.

Solution

sbt-revolver is a plugin that provides the ability to reload(compile and run)
the server when source files are changed.

Result

The hello-world example can now be run with sbt "~re-start" to enable the
feature.

Add sbt-revolver to the hello-world example
Problem

The documentation does not mention anything about reloading the server when
changes are made. There have also been issues created requesting this feature.

Solution

sbt-revolver is a plugin that provides the ability to reload(compile and run)
the server when source files are changed.

Result

The hello-world example can now be run with `sbt "~re-start"` to enable the
feature.
@codecov-io

This comment has been minimized.

codecov-io commented May 20, 2016

Current coverage is 96.14%

Merging #324 into master will increase coverage by 6.52%

  1. 2 files (not in diff) in ...twitter/finatra/json were modified. more
    • Misses -2
    • Hits +2
  2. 1 files (not in diff) in .../com/twitter/finatra were modified. more
    • Misses -2
    • Hits +2
  3. 3 files (not in diff) in ...twitter/finatra/http were modified. more
    • Misses -3
    • Hits +3
  4. 7 files (not in diff) in ...witter/finatra/utils were deleted. more
  5. 11 files (not in diff) in .../finatra/conversions were deleted. more
  6. 4 files (not in diff) in .../com/twitter/finatra were deleted. more
  7. 2 files (not in diff) in ...natra/thrift/routing were deleted. more
  8. 3 files (not in diff) in ...atra/thrift/internal were deleted. more
  9. 6 files (not in diff) in ...natra/thrift/filters were deleted. more
  10. 5 files (not in diff) in ...itter/finatra/thrift were deleted. more
@@             master       #324   diff @@
==========================================
  Files           380        190   -190   
  Lines          2911       2721   -190   
  Methods        2549       2549          
  Messages          0          0          
  Branches        177        168     -9   
==========================================
+ Hits           2609       2616     +7   
+ Misses          302        105   -197   
  Partials          0          0          

Powered by Codecov. Last updated by 653525c...cefc88c

@cacoco

This comment has been minimized.

Member

cacoco commented May 20, 2016

@fayimora Can you rebase this commit off of the develop branch? Thanks!

@fayimora

This comment has been minimized.

Contributor

fayimora commented May 23, 2016

Sure @cacoco any tips on how to achieve this? Seems like a simple git rebase master won't be ideal

@cacoco

This comment has been minimized.

Member

cacoco commented May 23, 2016

@fayimora I don't know the exact command. Searching produced this. Also, since the change is small you could also just re-do it from the develop branch.

@fayimora

This comment has been minimized.

Contributor

fayimora commented May 23, 2016

Yeah I think I will just re-do it on develop

@cacoco

This comment has been minimized.

Member

cacoco commented Jun 6, 2016

Merged in baabcf3

@cacoco cacoco closed this Jun 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment