Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle downstream exceptions and display the error handler. #38

Merged
merged 1 commit into from Mar 7, 2013

Conversation

@bmdhacks
Copy link
Contributor

commented Mar 7, 2013

Howdy, I'm a new guy at twitter working on zipkin.

Here's a patch I cooked up for a problem we're seeing when downstream finagle requests bubble up exceptions. Currently when a route returns Future.exception, finatra returns empty content on the socket. This patch handles these exceptions and routes to the error handlers where we can correctly return 500 status.

Handle downstream exceptions and display the error handler.
Currently when a route returns Future.exception, finatra returns empty content on the socket.
This patch handles these exceptions and routes to the error handlers where we can correctly return 500 status.

capotej added a commit that referenced this pull request Mar 7, 2013

Merge pull request #38 from bmdhacks/finagle_exceptions
Handle downstream exceptions and display the error handler.

@capotej capotej merged commit c79449c into twitter:master Mar 7, 2013

1 check passed

default The Travis build passed
Details
@capotej

This comment has been minimized.

Copy link
Contributor

commented Mar 7, 2013

Sweet, thanks! Just in time for the release I was going to do tonight! 👍

@bmdhacks

This comment has been minimized.

Copy link
Contributor Author

commented Mar 7, 2013

Nice, here's an example if you want to test the before/after:

    /**
     * Finagle error
     *
     * curl http://localhost:7070/errorfuture
     */
    get("/errorfuture") { request =>
      Future.exception(new Exception)
    }

cacoco pushed a commit that referenced this pull request May 13, 2015

Merge pull request #38 from bmdhacks/finagle_exceptions
Handle downstream exceptions and display the error handler.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.