fixed typing of jsonGenerator so it can be actually overridden #47
finaglehelper pushed a commit that referenced this pull request
Oct 26, 2017
Summary: Problem We would like to move TwitterServer's framework logging to the slf4j-api from util-logging (a thin scala wrapper over java.util.logging (JUL). This commit addresses issues: [#50](twitter/twitter-server#50) and [#47](twitter/twitter-server#47). Solution Update the composition of the TwitterServer trait to use the functionality from util/util-slf4j-api. Move specific logging implementation functionality into the appropriate sub-package. Provide backwards compatibility in the slf4j-jdk14 sub-package. JIRA Issues: CSL-4872 TBR=true Differential Revision: https://phabricator.twitter.biz/D101201
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.