New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed typing of jsonGenerator so it can be actually overridden #47

Merged
merged 1 commit into from Jun 13, 2013

Conversation

2 participants
@bmdhacks
Contributor

bmdhacks commented Jun 13, 2013

No description provided.

@bmdhacks

This comment has been minimized.

Contributor

bmdhacks commented Jun 13, 2013

Sorry, I was a big dummy. This is what I wanted to push. Sorry for the hassle.

capotej added a commit that referenced this pull request Jun 13, 2013

Merge pull request #47 from bmdhacks/JsonGenerator
fixed typing of jsonGenerator so it can be actually overridden

@capotej capotej merged commit 140e30c into twitter:master Jun 13, 2013

1 check passed

default The Travis CI build passed
Details
@capotej

This comment has been minimized.

Contributor

capotej commented Jun 13, 2013

No problem, have some other stuff I wanted to get out also, so it all worked out.

cacoco pushed a commit that referenced this pull request May 13, 2015

Merge pull request #47 from bmdhacks/JsonGenerator
fixed typing of jsonGenerator so it can be actually overridden

finaglehelper pushed a commit that referenced this pull request Oct 26, 2017

TwitterServer: Move TwitterServer framework to the slf4j-api
Summary: Problem

We would like to move TwitterServer's framework logging to
the slf4j-api from util-logging (a thin scala wrapper over
java.util.logging (JUL).

This commit addresses issues: [#50](twitter/twitter-server#50)
and [#47](twitter/twitter-server#47).

Solution

Update the composition of the TwitterServer trait to use the functionality
from util/util-slf4j-api. Move specific logging implementation functionality
into the appropriate sub-package. Provide backwards compatibility in the
slf4j-jdk14 sub-package.

JIRA Issues: CSL-4872

TBR=true

Differential Revision: https://phabricator.twitter.biz/D101201
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment