Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Adding lazy service #67
This pr aims to fix #66. The problem is that FinatraServer assigns the value of service during construction, which doesn't leave any chance for the additional filters that are added later to be taken into account. Making this field
Testing this change without exposing the service turned out to be difficult. I tried my best but I am aware that the test is not the healthiest one.
@twoism I actually wanted to write the test this way but the SpecHelper does not take the filters into account and furthermore the appService is not exposed therefore I could not find an easy way to test the filters as you described. However if I can refactor the SpecHelper then I can write a better test. I will try to do it soon-ish.
added a commit
this pull request
Oct 30, 2013
1.4.1 should be out on sonatype with these fixes: https://github.com/capotej/finatra/releases/tag/finatra-1.4.1 Thanks!