Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FinatraServer should take the generic Filters, not SimpleFilters #76

Merged
merged 1 commit into from Dec 19, 2013

Conversation

@pcalcado
Copy link
Contributor

commented Dec 9, 2013

I am not too sure if there was ever a reason to use the limited subtype instead of Filter, but this was requiring us to wrap the CorsFilter into a dummy SimpleFilter.

@capotej

This comment has been minimized.

Copy link
Contributor

commented Dec 19, 2013

Nice catch!

capotej added a commit that referenced this pull request Dec 19, 2013

Merge pull request #76 from pcalcado/master
FinatraServer should take the generic Filters, not SimpleFilters

@capotej capotej merged commit e83ea21 into twitter:master Dec 19, 2013

1 check passed

default The Travis CI build passed
Details

cacoco pushed a commit that referenced this pull request May 13, 2015

Merge pull request #76 from pcalcado/master
FinatraServer should take the generic Filters, not SimpleFilters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.