New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Bower and use default bootstrap.css in new projects #99

Merged
merged 12 commits into from Jan 14, 2014

Conversation

2 participants
@armandocanals
Contributor

armandocanals commented Jan 13, 2014

Adds a default index.html, bootstrap.css and bower configuration files to new Finatra projects. Script prompts user to install bower components only if bower is present in a user's PATH upon creating a new Finatra project.

.bowerrc Outdated
@@ -0,0 +1,3 @@
{

This comment has been minimized.

@capotej

capotej Jan 13, 2014

Contributor

Move this file to script/finatra/share/.bowerrc

bower.json Outdated
@@ -0,0 +1,21 @@
{

This comment has been minimized.

@capotej

capotej Jan 13, 2014

Contributor

Move this file to script/finatra/share/bower.json

echo " creating favicon.ico"
cp $_FINATRA_ROOT/../../src/main/resources/public/favicon.ico $root_path/$project_name/src/main/resources/public/
echo " creating bower.json"
cp $_FINATRA_ROOT/../../bower.json $root_path/$project_name/

This comment has been minimized.

@capotej

capotej Jan 13, 2014

Contributor

update to use share directory

cp $_FINATRA_ROOT/../../src/main/resources/public/favicon.ico $root_path/$project_name/src/main/resources/public/
echo " creating bower.json"
cp $_FINATRA_ROOT/../../bower.json $root_path/$project_name/
echo " creating .bowerrc"

This comment has been minimized.

@capotej

capotej Jan 13, 2014

Contributor

update to use share directory

@@ -34,7 +34,7 @@ class ExampleSpec extends FlatSpecHelper {
* curl http://localhost:7070/ => "hello world"
*/
get("/") { request =>
render.plain("hello world").toFuture
render.static("index.html").toFuture

This comment has been minimized.

bower.json Outdated
@@ -0,0 +1,21 @@
{
"name": "Finatra",

This comment has been minimized.

@capotej

capotej Jan 13, 2014

Contributor

Change name to ###PROJECT_NAME### so it gets replaced

bower.json Outdated
@@ -0,0 +1,21 @@
{
"name": "Finatra",
"version": "1.5.1",

This comment has been minimized.

@capotej

capotej Jan 13, 2014

Contributor

Make this 0.0.1

capotej added a commit that referenced this pull request Jan 14, 2014

Merge pull request #99 from armandocanals/bower
Add support for Bower and use default bootstrap.css in new projects, fixes #63

@capotej capotej merged commit 511b4fc into twitter:master Jan 14, 2014

1 check passed

default The Travis CI build passed
Details

cacoco pushed a commit that referenced this pull request May 13, 2015

Merge pull request #99 from armandocanals/bower
Add support for Bower and use default bootstrap.css in new projects, fixes #63
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment