allow normal edges to have their position changed;\nthis requires Multi o #55

Open
wants to merge 1 commit into
from

Projects

None yet

2 participants

@nkallen
nkallen commented Jun 2, 2011

allow normal edges to have their position changed;
this requires Multi operations to select full edges and propagate positions so that we don't reorder when we archive/unarchive;
furthermore, this requires position-decoding (uuid unapply) to be available in all bulk jobs so this was a hellish DI propagation;
a longer-term refactoring is to have a true uuid generator that doesn't require retries;
then, the uuid generator would only be needed in the execute compiler

Nick Kallen allow normal edges to have their position changed;\nthis requires Mul…
…ti operations to select full edges and propagate positions so that we don't reorder when we archive/unarchive;\nfurthermore, this requires position-decoding (uuid unapply) to be available in all bulk jobs so this was a hellish DI propagation;\na longer-term refactoring is to have a true uuid generator that doesn't require retries;

then, the uuid generator would only be needed in the execute compiler
4a3e5f3
@eaceaser eaceaser commented on the diff Jun 3, 2011
src/main/scala/com/twitter/flockdb/shards/SqlShard.scala
@@ -242,10 +236,12 @@ class SqlShard(val queryEvaluator: QueryEvaluator, val shardInfo: shards.ShardIn
}
def selectEdges(sourceId: Long, states: Seq[State], count: Int, cursor: Cursor) = {
+ require(!states.isEmpty, "must provide some states")
@eaceaser
eaceaser Jun 3, 2011

can we provide default behavior when the list is empty? we tend to not rely on runtime assertions.

@nkallen
nkallen Jun 3, 2011

I can default to all states or just normal, your pick. (note: It was broken before, I'm just making the error message nicer).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment