Fix issue #20: write uncompressed bytes if uncompressed size==compressed size #21

Merged
merged 3 commits into from Jun 3, 2011

Projects

None yet

3 participants

@miguno
Contributor
miguno commented Apr 24, 2011

The LZO specification says that we should write the uncompressed bytes
rather than the compressed bytes if the compressed buffer is actually
larger than the uncompresesd buffer.

To conform to the standard, this means we have to write the uncompressed
bytes also when they have exactly the same size as the compressed bytes.

miguno added some commits Apr 13, 2011
@miguno miguno Issue 20: write uncompressed bytes if uncompressed size==compressed size
The LZO specification says that we should write the uncompressed bytes
rather than the compressed bytes if the compressed buffer is actually
larger than the uncompresesd buffer.

To conform to the standard, this means we have to write the uncompressed
bytes also when they have exactly the same size as the compressed bytes.
72b439b
@miguno miguno Issue 20: add documentation for test case (introduced by commit 72b439b) 78e8199
@miguno miguno Bump version to 0.4.11 de0e47e
@miguno
Contributor
miguno commented Apr 26, 2011

Hi Kevin, I added the documentation for the test case and also bumped the version number to 0.4.11.

@miguno
Contributor
miguno commented May 13, 2011

Everything ok with the new pull request?

@miguno miguno closed this May 13, 2011
@miguno miguno reopened this May 13, 2011
@kevinweil
Contributor

Miguno, sorry this got lost! We're looking at this today and expect to have it merged EOD.

@rangadi
Contributor
rangadi commented Jun 1, 2011

will get patch in a release out today or tomorrow. btw, usually it is not required to bump the version. we will increase it when we make the release.

@rangadi rangadi merged commit 927df21 into twitter:master Jun 3, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment