Add an option to write lzo index file along with lzo file. #23

Merged
merged 4 commits into from Aug 4, 2011

Projects

None yet

2 participants

@rangadi
Twitter, Inc. member

This add an option in LzopCodec to write lzo index at same time as compression.

This needs to be enabled above LzopCodec since it has access only to outputstream, but not the filename. First use case would be in LzoOutputFormat in Elephant-bird.

@dvryaboy

style: please use { } here

@dvryaboy
Twitter, Inc. member

Let me do that.

Raghu Angadi added some commits Jul 26, 2011
@dvryaboy dvryaboy and 1 other commented on an outdated diff Jul 27, 2011
...java/com/hadoop/compression/lzo/LzopOutputStream.java
@@ -76,16 +76,19 @@ public class LzopOutputStream extends CompressorStream {
}
}
- public LzopOutputStream(OutputStream out, Compressor compressor,
@dvryaboy
dvryaboy Jul 27, 2011

We shouldn't get rid of a public constructor; rather we should delegate the old constructor to the new one, and del with a potential null indexOut there.

@rangadi
rangadi Jul 27, 2011

restored. Not sure why ended up removing the old constructor.

@dvryaboy dvryaboy merged commit eeafe76 into twitter:master Aug 4, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment