Sending pull request #48

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants

I need to use existed Configuration in DistributedLzoIndexer
Please, review it

Contributor

dvryaboy commented Jun 15, 2012

LGTM.
Raghu?

@rangadi rangadi commented on the diff Jul 20, 2012

...com/hadoop/compression/lzo/DistributedLzoIndexer.java
@@ -86,8 +86,10 @@ public int run(String[] args) throws Exception {
return 0;
}
- Configuration conf = new Configuration();
@rangadi

rangadi Jul 20, 2012

Contributor

ToolRunner() sets the conf. We should just remove it here. It will give you the same effect anyway.
I hate ToolRunner.

@rangadi

rangadi Jul 20, 2012

Contributor

we will have a different patch to fix it.

Contributor

traviscrawford commented Jul 20, 2012

Hey Alexey, thanks for the patch! We implemented slightly differently in #52 but its largely the same as this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment