Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sending pull request #48

Closed
wants to merge 1 commit into from
Closed

Sending pull request #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/java/com/hadoop/compression/lzo/DistributedLzoIndexer.java
View file
Open in desktop
Expand Up @@ -86,8 +86,10 @@ public int run(String[] args) throws Exception {
return 0; return 0;
} }


Configuration conf = new Configuration(); if (getConf() == null) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ToolRunner() sets the conf. We should just remove it here. It will give you the same effect anyway.
I hate ToolRunner.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we will have a different patch to fix it.

Job job = new Job(conf); setConf(new Configuration());
}
Job job = new Job(getConf());
job.setJobName("Distributed Lzo Indexer " + Arrays.toString(args)); job.setJobName("Distributed Lzo Indexer " + Arrays.toString(args));


job.setOutputKeyClass(Path.class); job.setOutputKeyClass(Path.class);
Expand Down