Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
branch: master
Commits on Feb 19, 2015
  1. @kevincrane

    Twitter MySQL 5.5.42.t19

    kevincrane authored
Commits on Feb 17, 2015
  1. @kevincrane
  2. @bkandasa @kevincrane
  3. @kevincrane

    Bug#19820550 : DISABLE SSL 3.0 SUPPORT IN OPENSSL

    Harin Vadodaria authored kevincrane committed
    Explicitly disable weaker SSL protocols.
  4. @kevincrane

    Bug#20201864 : UPGRADE TO YASSL 2.3.7

    Harin Vadodaria authored kevincrane committed
    Upgrading YaSSL from 2.3.5 to 2.3.7
    
    Reviewed-by : Kristofer Pettersson <kristofer.pettersson@oracle.com>
    Reviewed-by : Vamsikrishna Bhagi <vamsikrishna.bhagi@oracle.com>
  5. @kevincrane

    Bug#20041860: SLAVE ERROR WHEN DROP DATABASE

    s.sujatha authored kevincrane committed
    Fix:
    ===
    Backport Bug#11756194 to mysql-5.5. slave breaks if
    'drop database' fails on master and mismatched tables on
    slave.
    
    'DROP TABLE <deleted tables>' was binlogged when
    'DROP DATABASE' failed and at least one table was deleted
    from the database. The log event would lead slave SQL thread
    stop if some of the tables did not exist on slave.
    
    After this patch, It is always binlogged with 'IF EXISTS'
    option.
    
    Conflicts:
    	mysql-test/suite/binlog/r/binlog_database.result
    	sql/sql_db.cc
  6. @Thirunarayanan @kevincrane

    Bug #20144839 AFTER UPDATING TO MYSQL 5.6.22 SERVER

    Thirunarayanan authored kevincrane committed
    		CRASHES ON EVERY START ATTEMPT
    
    Description:
    ------------
    push_warning_printf function is used to print the warning message
    to the client. So this function should not invoke while recovering
    the server. Moreover current_thd is NULL while starting the server.
    
    Solution:
    ---------
     - Avoiding the warning to be printed while recovery.
    This patch already pushed in mysql-5.6.
  7. @Thirunarayanan @kevincrane

    Bug #19815702 TIS620: CRASH WITH MULTI TABLE DELETE

    Thirunarayanan authored kevincrane committed
    	- Moving the test case to correct place.
  8. @kevincrane

    Bug#20136840 REMOVE REMAINING REFERENCES TO BZR IN CMAKE SCRIPTS

    Tor Didriksen authored kevincrane committed
    Patch for 5.5
    
    Conflicts:
    	.bzrignore
    	cmake/cpack_source_ignore_files.cmake
    	cmake/make_dist.cmake.in
  9. @kevincrane

    Bug #19688008 CREATE_ASYMMETRIC_PUB_KEY: CRASHES IN OPENSSL

    Vamsikrishna Bhagi authored kevincrane committed
                  CODE
    
    Fixed a failure on pb2 caused by the patch previously
    pushed.
  10. @kevincrane

    Bug#18366947 : VALID DATE RANGE OF DUMMY SSL CERTS IS WAY TOO SHORT

    Harin Vadodaria authored kevincrane committed
    Generated new certificates with validity upto 2029.
  11. @kevincrane

    Bug #19688008 CREATE_ASYMMETRIC_PUB_KEY: CRASHES IN OPENSSL

    Vamsikrishna Bhagi authored kevincrane committed
                  CODE
    
    Problem: UDF doesn't handle the arguments properly when they
             are of string type due to a misplaced break.
             The length of arguments is also not set properly
             when the argument is NULL.
    
    Solution: Fixed the code by putting the break at right place
              and setting the argument length to zero when the
              argument is NULL.
  12. @MyDanny @kevincrane

    Merge branch 'mysql-5.5.41-release' into mysql-5.5

    MyDanny authored kevincrane committed
  13. @kevincrane

    Bug #16869534 QUERYING SUBSET OF COLUMNS DOESN'T USE TABLE CACHE; OPE…

    V S Murthy Sidagam authored kevincrane committed
    …NED_TABLES I
    
    Description: When querying a subset of columns from the information_schema.TABLES
    
    Analysis: When information about tables is collected for statements like
    "SELECT ENGINE FROM I_S.TABLES" we do not perform full-blown table opens
    in SE, instead we only use information from table shares from the Table
    Definition Cache or .FRMs. Still in order to simplify I_S implementation
    mock TABLE objects are created from TABLE_SHARE during this process.
    This is done by calling open_table_from_share() function with special
    arguments. Since this function always increments "Opened_tables" counter,
    calls to it can be mistakingly interpreted as full-blown table opens in SE.
    
    Note that claim that "'SELECT ENGINE FROM I_S.TABLES' statement doesn't
    use Table Cache" is nevertheless factually correct. But it misses the
    point, since such statements a) don't use full-blown TABLE objects and
    therefore don't do table opens b) still use Table Definition Cache.
    
    Fix: We are now incrementing the counter when db_stat(i.e open flags for ha_open(
    
    we have considered an optimization which would use TABLE objects from
    Table Cache when available instead of constructing mock TABLE objects,
    but found it too intrusive for stable releases.
  14. @kevincrane

    BUG#11747548: DETECT ORPHAN TEMP-POOL FILES, AND HANDLE GRACEFULLY

    Nisha Gopalakrishnan authored kevincrane committed
    Analysis:
    --------
    Certain queries using intrinsic temporary tables may fail due to
    name clashes in the file name for the temporary table when the
    'temp-pool' enabled.
    
    'temp-pool' tries to reduce the number of different filenames used for
    temp tables by allocating them from small pool in order to avoid
    problems in the Linux kernel by using a three part filename:
    <tmp_file_prefix>_<pid>_<temp_pool_slot_num>.
    The bit corresponding to the temp_pool_slot_num is set in the bit
    map maintained for the temp-pool when it used for the file name.
    It is cleared after the temp table is deleted for re-use.
    
    The 'create_tmp_table()' function call under error condition
    tries to clear the same bit twice by calling 'free_tmp_table()'
    and 'bitmap_lock_clear_bit()'. 'free_tmp_table()' does a delete
    of the table/file and clears the bit by calling the same function
    'bitmap_lock_clear_bit()'.
    
    The issue reported can be triggered under the timing window mentioned
    below for an error condition while creating the temp table:
    a) THD1: Due to an error clears the temp pool slot number used by it
       by calling 'free_tmp_table'.
    b) THD2: In the process of creating the temp table by using an unused
       slot number in the bit map.
    c) THD1: Clears the slot number used THD2 by calling
      'bitmap_lock_clear_bit()' after completing the call 'free_tmp_table'.
    d) THD3: Uses the slot number used the THD2 since it is freed by THD1.
       When it tries to create the temp file using that slot number,
       an error is reported since it is currently in use by THD2.
       [The error: Error 'Can't create/write to file
       '/tmp/#sql_277e_0.MYD' (Errcode: 17)']
    
    Another issue which may occur in 5.6 and trunk is that:
    When the open temporary table fails after its creation(due to ulimit
    or OOM error), the file is not deleted. Thus further attempts to use
    the same slot number in the 'temp-pool' results in failure.
    
    Fix:
    ---
    a) Under the error condition calling the 'bitmap_lock_clear_bit()'
       function to clear the bit is unnecessary since 'free_tmp_table()'
       deletes the table/file and clears the bit. Hence removed the
       redundant call 'bitmap_lock_clear_bit()' in 'create_tmp_table()'
       This prevents the timing window under which the issue reported
       can be seen.
    
    b) If open of the temporary table fails, then the file is deleted
       thus allowing the temp-pool slot number to be utilized for the
       subsequent temporary table creation.
    
    c) Also if the attempt to create temp table fails since it already
       exists, the temp-pool slot for it is marked as used, to avoid
       the problem from re-appearing.
  15. @kevincrane

    Bug#20043556 ALWAYS USE SAME FORMAT FOR INFO_SRC FILE

    Tor Didriksen authored kevincrane committed
    Change the format of 'git log' to produce INFO_SRC:
    
    commit: <commit hash>
    date: 2014-11-12 11:11:10 +0100
    build-date: 2014-11-17 15:24:16 +0100
    short: <abbreviated commit hash>
    branch: mysql-5.5
  16. @kevincrane

    Bug#20009543 SUPPORT-FILES/BUILD-TAGS TRANSITION TO GIT

    Tor Didriksen authored kevincrane committed
    Use 'git ls-files' to find source files for etags.
  17. @kevincrane

    Bug#19908468 PLACE CORRECT INFORMATION IN INFO_SRC AFTER TRANSITIONIN…

    Tor Didriksen authored kevincrane committed
    …G TO GIT
    
    Use 'git log -1; git branch' rather than 'bzr version-info'
  18. @kevincrane

    Bug#19890133 MAKE DIST USING BZR EXPORT EVEN FOR SOURCE DIR NOT A BZR…

    Tor Didriksen authored kevincrane committed
    … REPO
    
    For 'make dist': only use 'bzr export' if bzr root == ${CMAKE_SOURCE_DIR}
    Same thing for git.
    
    Conflicts:
    	cmake/make_dist.cmake.in
Commits on Feb 14, 2015
  1. @kevincrane

    Bug#17599258:- ERROR 1160 (08S01): GOT AN ERROR WRITING

    Arun Kuruvila authored kevincrane committed
                   COMMUNICATION PACKETS; FEDERATED TABLE
    
    Description:- Execution of FLUSH TABLES on a federated
    table which has been idle for wait_timeout (on the remote
    server) + tcp_keepalive_time, fails with an error,
    "ERROR 1160 (08S01): Got an error writing communication
    packets."
    
    Analysis:- During FLUSH TABLE execution the federated
    table is closed which will inturn close the federated
    connection. While closing the connection, federated server
    tries to communincate with the remote server. Since the
    connection was idle for wait_timeout(on the remote server)+
    tcp_keepalive_time, the socket gets closed. So this
    communication fails because of broken pipe and the error is
    thrown. But federated connections are expected to reconnect
    silently. And also it cannot reconnect because the
    "auto_reconnect" variable is set to 0 in "mysql_close()".
    
    Fix:- Before closing the federated connection, in
    "ha_federated_close()", a check is added which will verify
    wheather the connection is alive or not. If the connection
    is not alive, then "mysql->net.error" is set to 2 which
    will indicate that the connetion is broken. Also the
    setting of "auto_reconnect" variable to 0 is delayed and is
    done after "COM_QUIT" command.
    
    NOTE:- For reproducing this issue, "tcp_keepalive_time" has
    to be set to a smaller value. This value is set in the
    "/proc/sys/net/ipv4/tcp_keepalive_time" file in Unix
    systems. So we need root permission for changing it, which
    can't be done through mtr test. So submitting the patch
    without mtr test.
  2. @kevincrane

    Bug#19974500: SERVER 5.5 / DEBUG DOESN\'T COMPILE WITH GCC 4.9.1

    Jon Olav Hauglid authored kevincrane committed
    Fix broken gcc 4.9.1 debug build by removing end of line noise.
    
    In 5.6+ this issue was already fixed by:
    ------------------------------------------------------------
    revno: 3091
    committer: Davi Arnaut <davi.arnaut@oracle.com>
    branch nick: mysql-trunk
    timestamp: Mon 2011-05-16 11:30:54 -0300
    message:
      Fix warnings emitted by Clang.
  3. @kboortz @kevincrane

    Bug #18957951 RPMBUILD DEPENDENCY SCANNER ADDS DEPENDENCY ON NON-EXIS…

    kboortz authored kevincrane committed
    …TING PERL "HOSTNAMES"
    
    When building RPMs and using the "rpmbuild" automatic scanning for
    Perl dependencies, it might interpret "use hostnames" in the
    "mysql_config.pl" script usage comment as a Perl "use" statement.
    And then makes the resulting RPMs depends on a non-existing module
    Perl "hostnames". The comment was changed to prevent this.
  4. @Thirunarayanan @kevincrane

    Bug #19815702 TIS620: CRASH WITH MULTI TABLE DELETE

    Thirunarayanan authored kevincrane committed
    Description:
      Using correct length when moving to next field in cmp_ref. The store
    length already includes the length bytes of blobs, which is already considered
    earlier for blob types.
    	Approved by Mattias, Jimmy [rb-7088]
  5. @bkandasa @kevincrane

    Added sles11 repo packages

    bkandasa authored kevincrane committed
  6. @kevincrane

    Raise version number after cloning 5.5.41

    balasubramanian.kandasamy@oracle.com authored kevincrane committed
    Conflicts:
    	VERSION
  7. @kevincrane
Commits on Feb 13, 2015
  1. Fix build issues

    Inaam Rana authored
    * Fixed uninitialized variable warnings
    * Use no-strict-aliasing for maintainer and twitter builds
    * Update expired certificates causing SSL test failures (fixed in 5.5.42)
Commits on Feb 10, 2015
  1. @bkandasa @kevincrane

    Added sles11 repo packages

    bkandasa authored kevincrane committed
  2. @mithuncy @kevincrane

    Bug #19372926 : 5.5.38 FAILS FUNC_MATH MTR TEST.

    mithuncy authored kevincrane committed
    Issue :
    -------
    This seems for some platform -(LONGLONG_MIN) is
    not flagged as out of range.
    
    Fix:
    ----
    Fix is backported from mysql-5.6 bug 14314156.
    Fixed by adding an explicit test for this value in
    Item_func_neg::int_op().
    Conflicts:
    	sql/item_func.h
  3. @kevincrane

    Bug#19904003 INNODB_LIMIT_OPTIMISTIC_INSERT_DEBUG=1 CAUSES INFINITE P…

    Marko Makela authored kevincrane committed
    …AGE SPLIT
    
    The debug configuration parameter innodb_optimistic_insert_debug
    which was introduced for testing corner cases in B-tree handling
    had a bug in it. The value 1 would trigger an infinite sequence
    of page splits.
    
    Fix: When the value 1 is specified, disable this debug feature.
    Approved by Yasufumi Kinoshita
  4. @gurusami @kevincrane

    Bug #19908343 SERVER CRASHES WHEN EXECUTING ALTER TABLE

    gurusami authored kevincrane committed
    Problem:
    
    In the function dict_foreign_remove_from_cache(), the rb tree was updated
    without actually verifying whether the given foreign key object is there in the
    rb tree or not.  There can be an existing foreign key object with the same id
    in the rb tree, which must not be removed.  Such a scenario comes when an
    attempt is made to add a foreign key object with a duplicate identifier.
    
    Solution:
    
    When the foreign key object is removed from the dictionary cache, ensure
    that the foreign key object removed from the rbt is the correct one.
    
    rb#7168 approved by Jimmy and Marko.
  5. @kevincrane

    Bug#19584379 Reporting corruption may corrupt the innodb data dictionary

    Marko Makela authored kevincrane committed
    dict_set_corrupted(): Use the canonical way of searching for
    less-than-equal (PAGE_CUR_LE) and then checking low_match.
    
    The code that was introduced in MySQL 5.5.17 in
        Bug#11830883 SUPPORT "CORRUPTED" BIT FOR INNODB TABLES AND INDEXES
    could position the cursor on the page supremum, and then attempt
    to overwrite non-existing 7th field of the 1-field supremum record.
    
    Approved by Jimmy Yang
  6. @bkandasa @kevincrane

    Rpm 4.9 and newer is more strict regarding weekday in %changelog

    bkandasa authored kevincrane committed
    Conflicts:
    	support-files/mysql.spec.sh
  7. @bkandasa @kevincrane

    Fix changelog entries build failure

    bkandasa authored kevincrane committed
  8. @bkandasa @kevincrane

    Bug#19775856: When the socket option is relative, mysqld startup scri…

    bkandasa authored kevincrane committed
    …pt fails on CentOS 6
Something went wrong with that request. Please try again.