Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Branch: develop
Commits on Aug 27, 2015
  1. @travisbrown

    Release CSL stack

    travisbrown authored jenkins committed
    RB_ID=735615
  2. @travisbrown

    Update dependency and plugin versions in SBT builds

    travisbrown authored jenkins committed
    Problem
    
    Some of the dependency and plugin versions in our SBT builds were not
    up-to-date. These builds also still used non-SSL maven.twitter.com
    URLS.
    
    Solution
    
    Update versions and URLs in builds and docs. For Scrooge in particular
    this involved some additional changes because recent versions of some
    of the plugins it uses have switched to SBT's auto-plugin system.
    
    RB_ID=735075
Commits on Jul 27, 2015
  1. @vkostyukov

    Release CSL Stack

    vkostyukov authored jenkins committed
    RB_ID=721327
  2. @mosesn @vkostyukov

    Adding mnakamura to OWNERS

    mosesn authored vkostyukov committed
    RB_ID=702200
Commits on Jul 6, 2015
  1. @travisbrown

    Fix Travis CI and add code coverage for Finagle and related projects

    travisbrown authored jenkins committed
    Problem
    
    This change addresses three closely related problems. The first is that our
    Travis CI builds have been broken for a long time, in part because of the fact
    that since we don't publish snapshots, the current development versions aren't
    able to find their dependencies unless these are published locally. (Travis CI
    also recently changed containerized builds to be the default, and we're still
    unable to use the containerized build system with Finagle because of travis-ci
    issue #3120, so I've turned this off for the relevant projects.) The second
    issue is that we're not currently clearly indicating project status (whether a
    project is retired, deprecated, or actively maintained). Finally, we want to
    publish code coverage information for these projects.
    
    Solution
    
    This commit extends the work in Scrooge to provide a Travis CI script that
    downloads and publishes dependencies locally. It also adds retries for the
    dependency resolution and downloading step for each Travis CI config, as well as
    caching for dependencies. It also adds a shields.io badge to the top of each
    project README indicating the status of the project, and turns on Scoverage code
    coverage reporting (and publication to Coveralls) for each project.
    
    Result
    
    If our Travis builds are failing, it's much more likely to be for legitimate
    reasons. We also now clearly indicate code coverage stats and project status.
    
    RB_ID=704444
Commits on Jun 23, 2015
  1. @dschobel

    release CSL OSS

    dschobel authored jenkins committed
    release new minor version of all CSL OSS.
    
    twitter-server: 1.11.0
    scrooge: 3.19.0
    finagle-*: 6.26.0
    ostrich: 9.9.0
    util: 6.25.0
    
    RB_ID=701418
    TBR=true
Commits on Jun 22, 2015
  1. @marshalium

    ostrich: Prune removed metrics from TimeSeriesCollector

    marshalium authored jenkins committed
    Problem
    
    Once a stat was added to hourly or hourlyTimings it was never removed.
    Now once a Gauge or Counter does not exist in StatsSummary the stat
    is pruned.
    
    Solution
    
    Remove them in calls to `periodic`.
    
    RB_ID=694826
Commits on Jun 8, 2015
  1. @ascrane

    [iago] add wily support

    ascrane authored jenkins committed
    This adds wily support to iago. The 'finagle' victimType must be specified in the LauncherConfig for this to have any effect.
    
    The base twitter dtab is loaded in the parrot server, and an additional dtab will be concatenated from the dtabAdd setting in the ParrotLauncherConfig which is passed through to the ParrotServerConfig. A dtab override can also be specified at runtime with '-S dtab.add=$YOUR_DTAB'.
    
    The -S flag was added to the parrot launcher to allow arbitrary properties to be passed through to the parrot server. It may be desirable for the feeder to accept properties some day as well at some point. If a dtab is added at runtime, it is concatenated to the ParrotLauncherConfig setting. This will provide the least surprising behavior and will still allow full control over the dtab.
    
    RB_ID=679586
Commits on May 21, 2015
  1. Fix target types of 'fake' jar library targets

    ddavydov authored jenkins committed
    RB_ID=668822
    TBR=true
    NO_USER_HOOK=1
Commits on May 11, 2015
  1. @stevegury

    Goodbye

    stevegury authored jenkins committed
    Remove stevegury from various OWNERS files.
    
    RB_ID=658898
Commits on May 6, 2015
  1. @stevegury

    Fix sbt jar retrieval

    stevegury authored jenkins committed
    Problem
    
    Typesafe recently moved their jar repo to bintray.
    Now every jar fetching command (curl) fails because curl doesn't
    follow Http 302 by default.
    
    Solution
    
    Add the required parameter to curl to follow the 302 redirect.
    
    RB_ID=654736
    TBR=true
Commits on Apr 30, 2015
  1. Isolation: Remove deprecated globs usage in master

    Dave Benjamin authored jenkins committed
    RB_ID=647962
    USER_HOOK_ARGS=--i-am-evil -x birdcage/macaw-f5/web-client/.hooks/PRESUBMIT science/src/thrift/com/twitter/ads/schema/.hooks/PRESUBMIT .hooks/PRESUBMIT/validate-config-ini science/src/thrift/com/twitter/ads/dataservice/.hooks/PRESUBMIT
Commits on Apr 22, 2015
  1. @mosesn

    csl: Publish externally with pants, sbt, and friends

    mosesn authored jenkins committed
    Problem
    
    It's difficult to publish util, finagle, etc. because we haven't
    updated them for the new maven-less world.
    
    Solution
    
    Scripts that make it easy to publish with sbt and pants.  Bumped
    the server-set version because we stopped publishing thrift
    externally in ci.  Changed an ExitGuard test which broke under
    weird sbt conditions.
    
    Result
    
    We're in a position where we can start publishing finagle, etc
    again!
    
    RB_ID=633570
  2. @mansu

    Reducing the log level for negative data point message.

    mansu authored jenkins committed
    RB_ID=640548
Commits on Apr 20, 2015
  1. @travisbrown

    Update SBT's ScalaCheck and ScalaTest versions to match 3rdparty

    travisbrown authored jenkins committed
    RB_ID=627742
Commits on Apr 6, 2015
  1. @travisbrown

    Fix problems with SBT and Travis CI builds, update Scala and SBT vers…

    travisbrown authored jenkins committed
    …ions
    
    Problem
    
    SBT builds for Finagle and associated projects were failing for a number of
    reasons, including third-party dependency versions that had been updated for
    Pants but not SBT, new tests that are run differently by the SBT test runner,
    and changes to JSON serialization that don't work the same on Scala 2.10 and
    2.11. Our SBT and Scala versions were also out of date.
    
    Also Travis CI's container-based infrastructure currently has a bug that causes
    the build to crash when getting the local hostname with IPv4 on OpenJDK 7
    (reported in #3120 on GitHub). Moving back to the standard Travis infrastructure
    is a trivial change, so I've included it here.
    
    Solution
    
    I've updated the SBT and Scala versions throughout, and have updated third-party
    dependency versions to match the configuration in 3rdparty (note that I've
    followed the last update to scrooge/project/build.properties in not updating the
    custom SBT script for Scrooge). TwitterServer now uses scala.xml, which is a
    separate module in Scala 2.11, so I've added a conditional dependency in the SBT
    build.
    
    The new ExitGuard tests were failing on SBT because clients were being left open
    in other test suites. I've daemonized all of these clients so that they don't
    create exit guards.
    
    In JsonSinkTest in TwitterServer I've desugared an implicit conversion
    provided by a view bound because Scala 2.11 prohibits Object as the target of an
    implicit conversion.
    
    Because Jackson doesn't correctly serialize Scala case classes that are defined
    locally in vals on Scala 2.11, I've moved three case classes out of vals and
    into the enclosing objects, changing names where necessary to avoid collisions,
    and making each case class private to the object.
    
    I've also switched all projects with a custom SBT script back to the standard
    Travis CI infrastructure.
    
    Result
    
    We're on the most recent versions of Scala and SBT, the SBT builds actually
    work, and Travis CI won't fail spuriously on OpenJDK 7.
    
    RB_ID=619988
Commits on Mar 23, 2015
  1. @roanta

    ostrich: Remove "start up" test in AdminServiceConfigTest

    roanta authored jenkins committed
    Problem
    
    AdminServiceConfigTest allocated fixed ports which doesn't
    play nicely with our CI.
    
    Solution
    
    Instead of adding forwarders to AdminServiceConfig that could
    extract the underlying HttpServer address, I opted to delete
    this test for two reasons. First, it seemed like a silly test
    to verify that we open a socket. Secondly, AdminServiceConfig is
    deprecated in favor of AdminServiceFactory.
    
    RB_ID=610040
Commits on Mar 16, 2015
  1. @mosesn

    ostrich: Fix http path

    mosesn authored jenkins committed
    RB_ID=607778
    TBR=true
  2. @mosesn

    ostrich: Deprecate the dependency on util-eval

    mosesn authored jenkins committed
    Problem
    
    We want to eventually remove the dependency on util-eval in ostrich,
    but it's difficult today because RuntimeEnvironment assume util-eval.
    
    Solution
    
    Provide a separate API which is independent of util-eval, and
    deprecate the old one.
    
    Result
    
    We're in a position where we can remove ostrich's dependency on
    util-eval.
    
    RB_ID=605448
  3. @mosesn

    ostrich: Provide a registry endpoint

    mosesn authored jenkins committed
    Problem
    
    We need Ostrich folks to be able to export registry data too.
    
    Solution
    
    Add a registry endpoint to the Ostrich admin server, move the code
    that can be shared between Ostrich and TwitterServer into util-registry.
    
    Also added some tests for Roster and updated the version of jackson
    while I was in here.
    
    Result
    
    Ostrich folk can export registry data.
    
    RB_ID=605258
Commits on Mar 9, 2015
  1. @selvin

    [ostrich]: ServerConfig: Prefer configuring loggers with LoggerFactor…

    selvin authored jenkins committed
    …y when available over LoggerConfig
    
    RB_ID=591744
Commits on Mar 2, 2015
  1. @nshkrob

    ostrich: Fix flaky start and stop test

    nshkrob authored jenkins committed
    Problem
    
    The test expects a ConnectException: Connection refused if we connect to a service after shutdown. Very rarely (~1 in 1000 runs), the exception is not thrown.
    I think this is caused by the lingering client connection.
    
    Solution
    
    - Close the client connection before shutting down the service.
    - Use eventually around the intercept.
    - Also fix the ping test which potentially has the same problem.
    
    RB_ID=593486
  2. @mosesn

    util-app: Adds Flags to registry

    mosesn authored jenkins committed
    Problem
    
    Flags with interesting values should be added to the registry.
    
    Solution
    
    There is a solution in a few parts.
    
    1.  How to hook into flags?
    
    The simplest solution is to do it at read time.  Reading is done
    in a few different places, but the simplest way is to just put it
    in the getValue method of Flag, which works for both GlobalFlags and
    for regular Flags.
    
    2.  Which registry to register in?
    
    The registry is global, and it seems somewhat silly to program as
    if it's not, so I've taken the same approach as we do with Time.
    
    Result
    
    Flags are added to the registry after read time, and are structured
    like so:
    
    /registry/flags/foo = true
    
    RB_ID=587044
Commits on Feb 23, 2015
  1. @stuhood

    birdcage: Split out 3rdparty deps to be opened

    stuhood authored jenkins committed
    These 3rdparty BUILD files will be "open sourced" to support their (already opened) dependees. As a side benefit, the massive 3rdparty/BUILD file shrinks a bit.
    
    - Explode initial set of (open source dependee) 3rdparty deps out from 3rdparty/BUILD.* and into subdirectories
    
    This was produced by splitting out the dependencies of finagle, util, scrooge and twitter-server (computed via depmap: see attached ticket) manually into subdirectories, and then using a script like the following for each moved target:
    
        find . -name 'BUILD*' | xargs egrep --color=auto -i -s "$1" | xargs sed -i '' "s|$1|$2|g"
    
    RB_ID=560570
    USER_HOOK_ARGS=--i-am-evil -x birdcage/macaw-swift/PRESUBMIT/check-swoop
  2. @richunger

    [util-core]: Safeguard TimeFormat from misuse of "week year" ("YYYY")

    richunger authored jenkins committed
    Problem
    
    It is easy to mistakenly use "YYYY" instead of "yyyy" in a date pattern string.
    The only proper use of week year is in concert with the week number, e.g.
    "YYYY-ww".
    
    Solution
    
    Implement a java.text.DateFormat that checks the pattern on initialization,
    and use it from TimeFormat.
    
    Result
    
    Any format attempting to format non-week dates with the week year will
    fail on construction.
    
    RB_ID=552028
    TBR=true
Commits on Dec 30, 2014
  1. @travisbrown

    Use Travis CI's new container-based infrastructure

    travisbrown authored jenkins@bigbird committed
    Problem
    
    Travis CI just announced a new container-based infrastructure that provides
    faster builds, etc., and can be enabled by disabling sudo in the Travis config.
    
    Solution
    
    We don't need sudo for any of these projects, so we can disable it. I've also
    fixed a few minor issues with versions in the Travis configuration for scrooge,
    finagle, and twitter-server.
    
    RB_ID=547354
  2. @travisbrown

    Use master branch status only for Travis CI badges

    travisbrown authored jenkins@bigbird committed
    Problem
    
    Without a branch parameter in the image URL, the Travis CI badge will show the
    status of the latest build. We don't guarantee that develop branches will
    compile without local publication of dependencies, which means the badge may not
    always be accurate.
    
    Solution
    
    Add a branch parameter so that we only show the build status of master.
    
    RB_ID=544318
Commits on Dec 16, 2014
  1. @travisbrown @stevegury

    Enable Scala 2.11 SBT builds for util-eval, ostrich, and finagle-ostr…

    travisbrown authored stevegury committed
    …ich4
    
    Problem
    
    We want to publish 2.11 releases of Finagle subprojects that depend on Ostrich,
    which we have not previously built for 2.11 (because it has specs tests, and
    because it depends on scala-json and util-eval, neither of which previously
    worked on 2.11).
    
    Solution
    
    util-eval previously didn't work on 2.11 because `scala.ScalaObject` has been
    removed since 2.10. This is fixed here. The bulk of this commit is Rodrigo
    Lazoti's migration of Ostrich's tests from specs to ScalaTest (I'm not using his
    pull request since the PR also replaces scala-json with Jackson, which we don't
    want to do at this time to avoid breaking public APIs). This commit also
    reinstates util-eval and the Finagle subprojects that depend on Ostrich in their
    projects' cross-builds.
    
    Result
    
    util-eval, ostrich, finagle-ostrich4, finagle-example, and finagle-stress all
    build and pass tests on 2.11 (from SBT) for the first time.
    
    RB_ID=534127
Commits on Dec 12, 2014
  1. @stevegury

    Bump all sbt projects (util, ostrich, finagle, twitter-server)

    stevegury authored jenkins@bigbird committed
    Problem
    
    After looking at the finagle changelog, I discovered that we already had
    entries for finagle 6.23.0 and more for the current version.
    The previous version bump was then incorrect, the version needs to be
    greater than 6.23.0.
    
    Solution
    
    Bump the minor version of finagle, and for consistency I did the same
    thing for all the other related projects.
    Close the current section of the finagle changelog and name it "6.24.0".
    
    RB_ID=540180
Commits on Dec 11, 2014
  1. @stevegury

    Update sbt projet definitions of (util, ostrich, scoorge, twitter-ser…

    stevegury authored jenkins@bigbird committed
    …ver)
    
    Problem
    
    In order to release our libraries for the open-source community, we need to update
    the version of those.
    
    Solution
    
    Update the version in the sbt project definition.
    While I was there, update also sbt to the latest version and increase the jvm
    configuration for the code cache.
    
    RB_ID=537603
Commits on Dec 2, 2014
  1. @stevegury

    Finagle, Ostrich, Util: Fix sbt project definition

    stevegury authored jenkins@bigbird committed
    Problem
    
    Finagle was not compiling with sbt for multiple reasons:
    - the java compilation of AbstractCloseAwaitably.java required one extra import
    - finagle-httpx-compat required direct dependencies on finagle-http(x)
    
    Solution
    
    Fix the sbt project definition of Util/Finagle.
    While I was there, I cleaned up some scaladoc warning in util and
    some compilation warning in ostrich.
    
    RB_ID=525909
Commits on Nov 25, 2014
  1. Merge branch 'tmp' into develop

    jenkins@bigbird authored
Commits on Nov 21, 2014
  1. @bdd

    [split] twitter-server & ostrich: Drop reflection of an MX bean

    bdd authored CI committed
    Problem:
    BufferPoolMXBean was introduced in JDK 7 and for supporting JDK 6 we
    needed to invoke the class loader manually and use reflection to load it
    where available to provider direct byte buffer stats.  Now JDK 6 support
    is dropped, no justification is left for complex piece of code.
    
    Solution:
    Remove class loading and reflection.
    Import `java.lang.management.BufferPoolMXBean` interface and used it as
    a Platform MX Bean.
    
    Result:
    No observable changes in exported stats.
    
    RB_ID=521207
Commits on Nov 18, 2014
  1. Merge branch 'tmp' into develop

    jenkins@bigbird authored
Commits on Nov 10, 2014
  1. @liyichao

    [split] ostrich: fix typos in HistogramSpec

    liyichao authored CI committed
    Fix the typos in `com.twitter.ostrich.stats.HistogramSpec`.
    
    RB_ID=508599
Something went wrong with that request. Please try again.