Commits on Jul 22, 2016
  1. @cacoco

    ostrich, scrooge, finagle, twitter-server, finatra: Update TravisCI c…

    …onfigurations
    
    Problem
    
    We'd like to consolidate the logic of building the DAG that represents
    the dependency graph of Twitter OSS projects on each other. We recently
    introduced the Dodo project for this and now want to use it across our
    OSS TravisCI build configurations.
    
    See: https://github.com/twitter/dodo
    
    Solution
    
    Update the .travis.yml for projects which were previously using different
    scripts to build their dependencies to use Dodo.
    
    Result
    
    Less moving pieces for when changes need to happen.
    
    RB_ID=854739
    cacoco committed with jenkins Jul 22, 2016
Commits on Jul 7, 2016
  1. @vkostyukov

    csl: Release CSL libraries

    Problem / Solution
    
    Finagle 6.36
    Util 6.35
    Ostrich 9.19
    TwitterServer 1.21
    Finatra 2.2.0
    Scrooge 4.8.0
    
    RB_ID=849873
    vkostyukov committed with jenkins Jul 7, 2016
Commits on Jun 29, 2016
  1. delete scala-json

    Problem
    
    Building finagle for Scala 2.12 requires taking care of scala-json (a dependency of ostrich, which is a dependency of finagle-ostrich4).
    
    Solution
    
    scala-json has been deprecated for a year and a half and doesn't really provide any value over Jackson. Delete scala-json and change its consumers (pretty much just Ostrich) to use Jackson instead.
    Because scala-json [sorts keys when serializing](https://github.com/twitter/scala-json/blob/5f1a8664bbe382bbd12c5ba62319f034f0fbb2d4/src/main/scala/com/twitter/json/Json.scala#L172), I've preserved that behavior in places when serializing with Jackson. Per the JSON RFC, the order of keys should not matter, but given the level of support we are currently giving Ostrich, I don't feel it's worth the time/risk to stop sorting. Opinions welcome.
    
    Result
    
    scala-json is no longer a blocker to Finagle supporting Scala 2.12.
    
    RB_ID=846541
    Matt Landis committed with jenkins Jun 28, 2016
Commits on Jun 8, 2016
  1. @cacoco

    util, ostrich, scrooge, finagle, twitter-server: Update to use codeco…

    …v.io
    
    Problem
    
    We'd like to update to different code coverage tooling.
    
    Solution
    
    Update the projects travis.yml and plugins.sbt files accordingly.
    
    Result
    
    New code coverage instrumentation.
    
    RB_ID=840597
    cacoco committed with jenkins Jun 8, 2016
Commits on Jun 6, 2016
  1. @sveinnfannar

    ostrich: Fix sbt error when configuring project settings

    Problem
    
    Sbt was failing on the following error:
    java.lang.IllegalArgumentException: Cannot add dependency
    'org.scala-lang#scala-compiler;2.11.8' to configuration
    'ensime-internal' of module com.twitter#ostrich_2.11;9.18.0-SNAPSHOT
    because this configuration doesn't exist!
    
    SBT version: 0.13.11 and Scala version: 2.11.7
    
    Solution
    
    Use Project#settings because some sbt plugins may try to modify settings
    at Project construction.
    See:
    http://stackoverflow.com/questions/35067187/sbt-idiomatic-way-to-add-settings/35545637#35545637
    
    Why
    
    Finagle's dependency setup script was failing because it depends on this
    repo.
    
    Signed-off-by: Moses Nakamura <mnakamura@twitter.com>
    
    RB_ID=837545
    sveinnfannar committed with jenkins Jun 3, 2016
  2. @ReadmeCritic

    Update README URLs based on HTTP redirects

    Signed-off-by: Kevin Oliver <koliver@twitter.com>
    
    RB_ID=838588
    ReadmeCritic committed with jenkins Jun 2, 2016
Commits on May 30, 2016
  1. @mosesn

    csl: Bumped to scalatest 2.2.6

    Problem
    
    We want to start cross-building for scala 2.12.x, but there isn't
    a published 2.2.4 on 2.12.x
    
    Solution
    
    Bump to scalatest 2.2.6, where there is a published version on
    2.12.x.
    
    Result
    
    Crossbuilding goes more smoothly!
    
    RB_ID=835850
    mosesn committed with jenkins May 25, 2016
  2. Fix some Ostrich "Unused import" warnings

    RB_ID=835649
    Joseph Boyd committed with jenkins May 23, 2016
Commits on May 9, 2016
  1. @kevinoliver

    Switch to Java 8 and Scala 2.11

    Problem
    
    Its time to drop support for Java 7 and Scala 2.10 as per the blog
    post [1].
    
    Solution
    
    Update sbt builds.
    
    [1] https://finagle.github.io/blog/2016/04/20/scala-210-and-java7/
    
    RB_ID=828898
    kevinoliver committed with jenkins May 5, 2016
Commits on Apr 27, 2016
  1. @cacoco

    Twitter OSS: Prepare libraries for next release

    Problem
    
    We're releasing the next versions of the Twitter OSS libraries:
    util - 6.34.0
    ostrich - 9.18.0
    scrooge - 4.7.0
    finagle - 6.35.0
    twitter-server - 1.20.0
    finatra - 2.1.6
    
    Solution
    
    Update to the release version.
    
    RB_ID=826660
    cacoco committed with jenkins Apr 27, 2016
Commits on Apr 25, 2016
  1. @cacoco

    finatra/twitter-server/common/ostrich: Update to register TwitterServ…

    …er, AbstractApplication and Ostrich as libraries in /admin/registry.json
    
    Problem
    
    AbstractApplication, Ostrich and TwitterServer do not register themselves as
    libraries in the /admin/registry.json.
    
    Solution
    
    Update com.twitter.server.AdminHttpServer in twitter-server,
    com.twitter.ostrich.admin.AdminHttpService in ostrich, and the
    com.twitter.common.application.modules.RegistryModule for AbstractApplication
    to register themselves as libraries in the /admin/registry.json Registry.
    Also update Finatra as necessary since its superclass from TwitterServer now
    performs the library registration.
    
    Result
    
    TwitterServer, AbstractApplication (using the RegistryModule) and Ostrich
    applications will be registered in the library section of the
    /admin/registry.json.
    
    RB_ID=825129
    cacoco committed with jenkins Apr 25, 2016
Commits on Mar 21, 2016
  1. @kevinoliver

    util-core: Remove deprecated Future.apply methods

    Problem
    
    `c.t.util.Future.apply` is deprecated because it makes it a little too
    easy to do a blocking operation.
    
    Solution
    
    Replace usages with `c.t.util.Await.result` so it is explicit.
    
    RB_ID=811617
    TBR=true
    kevinoliver committed with jenkins Mar 18, 2016
Commits on Mar 10, 2016
  1. @cacoco

    Bump versions - util/ostrich/finagle/scrooge/twitter-server

    Prepare libraries for release.
    
    RB_ID=809587
    cacoco committed with jenkins Mar 10, 2016
Commits on Feb 29, 2016
  1. @grimreaper

    Fix some lint errors in CONFIG.ini and OWNERS - missing newlines - tr…

    …ailing whitespace
    
    RB_ID=804492
    TBR=true
    NO_USER_HOOK=1
    grimreaper committed with jenkins Feb 26, 2016
Commits on Feb 8, 2016
  1. @taylorleese

    ostrich: cleanup travis build

    RB_ID=797683
    taylorleese committed with jenkins Feb 5, 2016
Commits on Feb 4, 2016
  1. @cacoco

    release: Prepare libraries for OSS release

    RB_ID=796660
    cacoco committed with jenkins Feb 4, 2016
Commits on Feb 2, 2016
  1. @cacoco

    Prepare for open-source release of CSL libraries

    RB_ID=796003
    cacoco committed with jenkins Feb 2, 2016
  2. @tonyd3

    ostrich: Add deprecation flag to ostrich pants file.

    Problem
    Ostrich has been deprecated for a while. So it'd be
    nice to get a warning if people are still using it.
    
    Solution
    Add a deprecation tag to Ostrich's BUILD file.
    
    RB_ID=795520
    tonyd3 committed with jenkins Feb 1, 2016
Commits on Dec 3, 2015
  1. @vkostyukov

    csl: Release OSS libraries

    Finagle 6.31
    Util 6.30
    Scrooge 4.2
    TwitterServer 1.16
    Ostrich 9.14
    
    RB_ID=774633
    TBR=true
    vkostyukov committed with jenkins Dec 3, 2015
Commits on Nov 30, 2015
  1. maven layout goes away

    RB_ID=771595
    NO_USER_HOOK=1
    yic committed with jenkins Nov 24, 2015
Commits on Nov 23, 2015
  1. @mosesn

    csl: Replace === with == in scalatest 2.x tests

    Problem
    
    We've been nagging each other about == vs ===.
    
    Solution
    
    ag -l ' === ' \
      ./util \
      ./ostrich \
      ./finagle \
      ./twitter-server \
      ./scrooge \
      ./twitter-server-internal | \
      grep '\.scala' | \
      xargs sed -i '' 's/ === / == /'
    
    ag -l ' ===' \
      ./util \
      ./ostrich \
      ./finagle \
      ./twitter-server \
      ./scrooge \
      ./twitter-server-internal | \
      grep '\.scala' | \
      xargs sed -i '' 's/ ===$/ ==/'
    
    Result
    
    No more === nags in RB
    
    RB_ID=766849
    mosesn committed with jenkins Nov 16, 2015
Commits on Oct 30, 2015
  1. @vkostyukov

    csl: Add Gitter badges and fix HipChat template and skip flaky tests

    There are (still) plenty of problems with our Github repos:
    
    a) Finagle build is broken;
    b) READMEs don't have a link to Gitter room;
    
    Solution
    
    a) Add `SKIP_FLAKY` env variable to Travis' config to skip all the
       flakey tests;
    b) Add Gitter badge for all the projects (except for Ostrich) that
       redirects to Finagle's room;
    
    RB_ID=761629
    vkostyukov committed with jenkins Oct 30, 2015
Commits on Oct 28, 2015
  1. @vkostyukov

    csl: Fix OSS builds

    Problem
    OSS build is still broken by the following reasons:
    
    1. My recent patch of `bin/travisci` had a typo under Scrooge (`.sbt` instead `./sbt`). Sorry.
    2. Sbt runs the tests in the order that differers from pants. And somehow, the order matters
       for `fiangle-http` due to some tests that use "addr=lable" address format. The reason for
       this is a global mutable state per `ServerRegistry` that is shared acroos Finagle instance
       and _overrides_ the server label.
    3. Finagle uses an old version of scrooge-sbt-plugin that had [a bug dealing with hierarchical
       thrift structures][1].
    
    Solution
    
    1. Fix typo in `scrooge/bin/travisci`.
    2. Do not use `addr=label` format as address in tests to avoid using `ServerRegistry`.
    3. Update Scrooge to the [most recent version][2].
    
    RB_ID=760532
    vkostyukov committed with jenkins Oct 28, 2015
Commits on Oct 27, 2015
  1. @vkostyukov

    csl: Fix TravisCI builds

    Problem
    TwitterServer depends on `finagle-zipkin`, which depends on `finagle-thrift`,
    which depends on `finagle-core`, which depends on `scrooge-core`.
    
    Solution
    Publish local all the required dependencies for twitter-server. Cleanup the rest
    of the travisci scripts.
    
    RB_ID=759759
    vkostyukov committed with jenkins Oct 27, 2015
Commits on Oct 15, 2015
  1. @roanta

    csl: bump lib versions

    RB_ID=756082
    TBR=true
    roanta committed with jenkins Oct 15, 2015
Commits on Oct 12, 2015
  1. @vkostyukov

    util-core: Remove deprecated methods on Time and Duration

    RB_ID=751771
    TBR=true
    vkostyukov committed with jenkins Oct 8, 2015
  2. @dschobel

    make 2.11.7 the default scala version for csl OSS

    Make 2.11.7 the default scala version for csl OSS and bump patch
    level of 2.10.
    
    RB_ID=752868
    dschobel committed with jenkins Oct 7, 2015
Commits on Sep 28, 2015
  1. @nshkrob

    Release CSL libraries (Sept 2015).

    - Release finagle, ostrich, scrooge, twitter-server, util (Sept 2015).
    
    RB_ID=747942
    nshkrob committed with jenkins Sep 28, 2015
Commits on Sep 10, 2015
  1. @travisbrown

    Release CSL stack (redoing because of Scrooge publication failure)

    RB_ID=736143
    travisbrown committed with jenkins Aug 28, 2015
Commits on Aug 27, 2015
  1. @travisbrown

    Release CSL stack

    RB_ID=735615
    travisbrown committed with jenkins Aug 27, 2015
  2. @travisbrown

    Update dependency and plugin versions in SBT builds

    Problem
    
    Some of the dependency and plugin versions in our SBT builds were not
    up-to-date. These builds also still used non-SSL maven.twitter.com
    URLS.
    
    Solution
    
    Update versions and URLs in builds and docs. For Scrooge in particular
    this involved some additional changes because recent versions of some
    of the plugins it uses have switched to SBT's auto-plugin system.
    
    RB_ID=735075
    travisbrown committed with jenkins Aug 27, 2015
Commits on Jul 27, 2015
  1. @vkostyukov

    Release CSL Stack

    RB_ID=721327
    vkostyukov committed with jenkins Jul 27, 2015
  2. @mosesn @vkostyukov

    Adding mnakamura to OWNERS

    RB_ID=702200
    mosesn committed with vkostyukov Jul 20, 2015
Commits on Jul 6, 2015
  1. @travisbrown

    Fix Travis CI and add code coverage for Finagle and related projects

    Problem
    
    This change addresses three closely related problems. The first is that our
    Travis CI builds have been broken for a long time, in part because of the fact
    that since we don't publish snapshots, the current development versions aren't
    able to find their dependencies unless these are published locally. (Travis CI
    also recently changed containerized builds to be the default, and we're still
    unable to use the containerized build system with Finagle because of travis-ci
    issue #3120, so I've turned this off for the relevant projects.) The second
    issue is that we're not currently clearly indicating project status (whether a
    project is retired, deprecated, or actively maintained). Finally, we want to
    publish code coverage information for these projects.
    
    Solution
    
    This commit extends the work in Scrooge to provide a Travis CI script that
    downloads and publishes dependencies locally. It also adds retries for the
    dependency resolution and downloading step for each Travis CI config, as well as
    caching for dependencies. It also adds a shields.io badge to the top of each
    project README indicating the status of the project, and turns on Scoverage code
    coverage reporting (and publication to Coveralls) for each project.
    
    Result
    
    If our Travis builds are failing, it's much more likely to be for legitimate
    reasons. We also now clearly indicate code coverage stats and project status.
    
    RB_ID=704444
    travisbrown committed with jenkins Jun 30, 2015
Commits on Jun 23, 2015
  1. @dschobel

    release CSL OSS

    release new minor version of all CSL OSS.
    
    twitter-server: 1.11.0
    scrooge: 3.19.0
    finagle-*: 6.26.0
    ostrich: 9.9.0
    util: 6.25.0
    
    RB_ID=701418
    TBR=true
    dschobel committed with jenkins Jun 23, 2015