Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a comprehensive test corpus for the parser #79

Closed
xeno-by opened this issue Mar 29, 2018 · 2 comments
Closed

Add a comprehensive test corpus for the parser #79

xeno-by opened this issue Mar 29, 2018 · 2 comments
Labels
Milestone

Comments

@xeno-by
Copy link
Contributor

xeno-by commented Mar 29, 2018

I think we should do the same thing that we do in scalameta/scalameta - hand-pick a huge corpus of Scala files and write a test that ensures that our scanner and parser work for them in a reasonable fashion.

@xeno-by xeno-by added the Parse label Mar 29, 2018
@xeno-by xeno-by added this to the [M3] Write SemanticDB milestone Mar 29, 2018
@xeno-by
Copy link
Contributor Author

xeno-by commented Mar 30, 2018

One cool thing that I liked about our tests is the fact that they verify that all characters in all sources are covered by tokens, with every character covered exactly by one token.

Another useful thing to check is the fact that all trees have positions.

@xeno-by xeno-by changed the title Add a comprehensive test corpus for the scanner Add a comprehensive test corpus for the parser Mar 31, 2018
@xeno-by
Copy link
Contributor Author

xeno-by commented Jul 7, 2018

checkparse introduced in #85 is pretty thorough, so that's the half of the ticket. The other half will be figured out and ticketed once we tackle #88.

@xeno-by xeno-by closed this as completed Jul 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

1 participant