Permalink
Browse files

review feedback

  • Loading branch information...
1 parent 05a8c5c commit 41454f2065c42c2a27314ff454765d7528ca8322 Robey Pointer committed Nov 17, 2011
@@ -86,7 +86,7 @@ end
root = File.expand_path(File.dirname(__FILE__) + "/../lib/template")
-Dir["#{root}/**/*"].select{|path| File.file?(path)}.each do |path|
+Dir["#{root}/**/*"].select { |path| File.file?(path) }.each do |path|
relative = path.sub("#{root}/", "")
content = File.read(path)
template = ERB.new(content, nil, nil, "@output")
@@ -18,7 +18,7 @@ class BirdNameProject(info: ProjectInfo) extends StandardServiceProject(info)
with CompileThriftRuby
with CompileThriftScroogeMixin
{
- val finagleVersion = "1.9.5"
+ val finagleVersion = "1.9.6"
val finagleC = "com.twitter" % "finagle-core" % finagleVersion
val finagleT = "com.twitter" % "finagle-thrift" % finagleVersion
@@ -10,6 +10,7 @@ import thrift._
class BirdNameServiceImpl(config: BirdNameServiceConfig) extends BirdNameService.ThriftServer {
val serverName = "BirdName"
val thriftPort = config.thriftPort
+ override val tracerFactory = config.tracerFactory
/**
* These services are based on finagle, which implements a nonblocking server. If you
@@ -1,6 +1,7 @@
package com.twitter.birdname
package config
+import com.twitter.finagle.tracing.{NullTracer, Tracer}
import com.twitter.logging.Logger
import com.twitter.logging.config._
import com.twitter.ostrich.admin.{RuntimeEnvironment, ServiceTracker}
@@ -10,6 +11,7 @@ import thrift._
class BirdNameServiceConfig extends ServerConfig[BirdNameService.ThriftServer] {
var thriftPort: Int = 9999
+ var tracerFactory: Tracer.Factory = NullTracer.factory
def apply(runtime: RuntimeEnvironment) = new BirdNameServiceImpl(this)
}

0 comments on commit 41454f2

Please sign in to comment.