Skip to content
Browse files

Merge pull request #1573 from twitter/oscar/mappablebyteswritable

Make Writeable sources Mappable to get toIterator
  • Loading branch information...
2 parents 8b8230f + ee3a654 commit cfc07959cf3022737f62a337e72752878db29c29 @rubanm rubanm committed on GitHub Jun 21, 2016
Showing with 4 additions and 3 deletions.
  1. +4 −3 scalding-core/src/main/scala/com/twitter/scalding/WritableSequenceFile.scala
View
7 scalding-core/src/main/scala/com/twitter/scalding/WritableSequenceFile.scala
@@ -51,7 +51,7 @@ case class WritableSequenceFile[K <: Writable: Manifest, V <: Writable: Manifest
with WritableSequenceFileScheme
with LocalTapSource
with TypedSink[(K, V)]
- with TypedSource[(K, V)] {
+ with Mappable[(K, V)] {
override val fields = f
override val keyType = manifest[K].runtimeClass.asInstanceOf[Class[_ <: Writable]]
@@ -73,14 +73,15 @@ object MultipleWritableSequenceFiles {
}
/**
- * This is only a TypedSource as sinking into multiple directories is not well defined
+ * This is only a TypedSource (which is a superclass of Mappable) as sinking into multiple directories
+ * is not well defined
*/
case class MultipleWritableSequenceFiles[K <: Writable: Manifest, V <: Writable: Manifest](
p: Seq[String], f: Fields)
extends FixedPathSource(p: _*)
with WritableSequenceFileScheme
with LocalTapSource
- with TypedSource[(K, V)] {
+ with Mappable[(K, V)] {
override val fields = f
override val keyType = manifest[K].runtimeClass.asInstanceOf[Class[_ <: Writable]]

0 comments on commit cfc0795

Please sign in to comment.
Something went wrong with that request. Please try again.