Add implicit Ordering[RichDate] #1512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see scala design issue: https://issues.scala-lang.org/browse/SI-8541 that causes the following for tuples with RichDate: /Users/oscar/oss/scalding/scalding-date/src/test/scala/com/twitter/scalding/DateTest.scala:139: diverging implicit expansion for type ((String, com.twitter.scalding.RichDate)) => Comparable[(String, com.twitter.scalding.RichDate)] [error] starting with method $conforms in object Predef [error] implicitly[Ordering[(String, RichDate)]] [error] ^ [error] one error found [error] (scalding-date/test:compileIncremental) Compilation failed [error] Total time: 5 s, completed Feb 10, 2016 2:27:14 PM
|
+1 |
johnynek
added a commit
that referenced
this pull request
Feb 11, 2016
Add implicit Ordering[RichDate]
| @@ -61,6 +61,10 @@ object RichDate { | |||
| } | |||
|
|
|||
| def now: RichDate = RichDate(System.currentTimeMillis()) | |||
|
|
|||
| implicit def richDateOrdering: Ordering[RichDate] = new Ordering[RichDate] { | |||
| def compare(a: RichDate, b: RichDate) = java.lang.Long.compare(a.timestamp, b.timestamp) | |||
There was a problem hiding this comment.
Should we call the compare function inside the richdate's instead? just so as we avoid any potential future drift.
(Curious I didn't think defining both Ordered and Ordering would get around the bug totally, but good!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see scala design issue: https://issues.scala-lang.org/browse/SI-8541
that causes the following for tuples with RichDate: