Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove a few warnings #1720

Merged
merged 3 commits into from Sep 24, 2017

Conversation

Projects
None yet
4 participants
@johnynek
Copy link
Collaborator

johnynek commented Sep 23, 2017

I'm trying to chip away at the giant wall of warnings we have.

review @ttim @ianoc ?

@@ -54,7 +54,7 @@ private[scalding] class ConfPropertiesHfsTap(
* Changes here however will not show up in the hadoop UI
*/
trait HfsConfPropertySetter extends HfsTapProvider {
@deprecated("Tap config is deprecated, use sourceConfig or sinkConfig directly. In cascading configs applied to sinks can leak to sources in the step writing to the sink.")
@deprecated("Tap config is deprecated, use sourceConfig or sinkConfig directly. In cascading configs applied to sinks can leak to sources in the step writing to the sink.", "2017-01-12")

This comment has been minimized.

Copy link
@piyushnarang

piyushnarang Sep 23, 2017

Collaborator

might have been nice if we could tie this to a scalding version. E.g. deprecated since 0.17.1 or so..

This comment has been minimized.

Copy link
@johnynek

johnynek Sep 23, 2017

Author Collaborator

I can fix that.

johnynek added some commits Sep 23, 2017

@johnynek johnynek merged commit a9215e6 into develop Sep 24, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@johnynek johnynek deleted the oscar/clean-warnings0 branch Sep 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.