Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Feature/clean up tuplegetter #278

Closed
wants to merge 6 commits into
from

Conversation

Projects
None yet
3 participants
Collaborator

johnynek commented Jan 16, 2013

No description provided.

@azymnis azymnis commented on the diff Jan 16, 2013

...scala/com/twitter/scalding/GeneratedConversions.scala
@@ -1,25 +1,9 @@
-/*
@azymnis

azymnis Jan 16, 2013

Contributor

We probably still want the license headers here or Chris A will be angry.

@johnynek

johnynek Jan 16, 2013

Collaborator

Can you copyright generated code?

@azymnis azymnis commented on the diff Jan 16, 2013

...scala/com/twitter/scalding/GeneratedConversions.scala
@@ -1100,6 +664,428 @@ trait GeneratedConversions extends LowPriorityConversions {
}
def arity = 22
}
+}
+trait GeneratedTupleSetters extends LowPriorityTupleSetters {
+
+ implicit object Tup1Setter extends TupleSetter[Tuple1[_]] {
+ override def apply(arg : Tuple1[_]) = {
+ val tup = new Tuple
@azymnis

azymnis Jan 16, 2013

Contributor

Were we not talking about not instantiating Tuple, but keeping one around for each setter?

@azymnis

azymnis Jan 16, 2013

Contributor

I guess we should probably do this as a separate diff though, right?

@johnynek

johnynek Jan 16, 2013

Collaborator

Yes, I think it should be in a separate diff.

Collaborator

sritchie commented Feb 14, 2013

Happy to merge this -- 0.8.3 or 0.9.0?

Collaborator

sritchie commented Feb 14, 2013

Whoops, now I see the branch at the top.

@johnynek johnynek closed this May 23, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment