Update JobTest to call transformForRead on pipes. #297

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@arkajit
Contributor

arkajit commented Feb 2, 2013

I want JobTest to actually apply a transformForRead on it's sources. It doesn't seem to do this now in the CascadingLocal Test mode and that's foiling one of my job tests.

I haven't figured it out yet, but wanted to start a discussion on how to do this. My first attempt doesn't quite work, but it's a rough idea of what I'd like to be able to do. Thoughts?

@ghost ghost assigned azymnis and johnynek Feb 2, 2013

@azymnis

This comment has been minimized.

Show comment Hide comment
@azymnis

azymnis Feb 4, 2013

Contributor

See #298

Looks to me like JobTest is already calling transformForRead/transformForWrite since:

  1. This test is passing
  2. The code for this is in Source and not in JobTest
  3. I verified it with some printf debugging

So the bug must be elsewhere. Let's try and hunt this down tomorrow in person.

Contributor

azymnis commented Feb 4, 2013

See #298

Looks to me like JobTest is already calling transformForRead/transformForWrite since:

  1. This test is passing
  2. The code for this is in Source and not in JobTest
  3. I verified it with some printf debugging

So the bug must be elsewhere. Let's try and hunt this down tomorrow in person.

@johnynek

This comment has been minimized.

Show comment Hide comment
@johnynek

johnynek Feb 4, 2013

Collaborator

Yeah, I tried to find how to get it called, but I couldn't convince myself it wasn't actually called. I think this may be a folk theorem, or a special case bug, not a general situation.

Collaborator

johnynek commented Feb 4, 2013

Yeah, I tried to find how to get it called, but I couldn't convince myself it wasn't actually called. I think this may be a folk theorem, or a special case bug, not a general situation.

@johnynek johnynek closed this Feb 4, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment