Skip to content
This repository
Browse code

fix bug where services using binary fields wouldn't compile

  • Loading branch information...
commit 5e0a4983f2e67625177cc13ac67651ad7ea69750 1 parent 58b7c8f
authored May 29, 2012
1  scrooge-generator/src/main/resources/javagen/service.java
@@ -8,6 +8,7 @@
8 8
 import com.twitter.util.Future;
9 9
 import com.twitter.util.FutureEventListener;
10 10
 import java.net.InetSocketAddress;
  11
+import java.nio.ByteBuffer;
11 12
 import java.util.ArrayList;
12 13
 import java.util.List;
13 14
 import java.util.Map;
1  scrooge-generator/src/main/resources/scalagen/service.scala
@@ -5,6 +5,7 @@ import com.twitter.finagle.SourcedException
5 5
 import com.twitter.scrooge.{ThriftStruct, ThriftStructCodec}
6 6
 import com.twitter.util.Future
7 7
 import java.net.InetSocketAddress
  8
+import java.nio.ByteBuffer
8 9
 import org.apache.thrift.protocol._
9 10
 import org.apache.thrift.TApplicationException
10 11
 import scala.collection.mutable
6  scrooge-generator/src/test/resources/binaryservice.thrift
... ...
@@ -0,0 +1,6 @@
  1
+namespace java thrift.test
  2
+
  3
+// this service will blow up during compile unless "binary" types work.
  4
+service BinaryService {
  5
+  binary fetchBlob(1: i64 id)
  6
+}

0 notes on commit 5e0a498

Please sign in to comment.
Something went wrong with that request. Please try again.