Permalink
Browse files

fix bug where services using binary fields wouldn't compile

  • Loading branch information...
1 parent 58b7c8f commit 5e0a4983f2e67625177cc13ac67651ad7ea69750 Robey Pointer committed May 30, 2012
View
1 scrooge-generator/src/main/resources/javagen/service.java
@@ -8,6 +8,7 @@
import com.twitter.util.Future;
import com.twitter.util.FutureEventListener;
import java.net.InetSocketAddress;
+import java.nio.ByteBuffer;
import java.util.ArrayList;
import java.util.List;
import java.util.Map;
View
1 scrooge-generator/src/main/resources/scalagen/service.scala
@@ -5,6 +5,7 @@ import com.twitter.finagle.SourcedException
import com.twitter.scrooge.{ThriftStruct, ThriftStructCodec}
import com.twitter.util.Future
import java.net.InetSocketAddress
+import java.nio.ByteBuffer
import org.apache.thrift.protocol._
import org.apache.thrift.TApplicationException
import scala.collection.mutable
View
6 scrooge-generator/src/test/resources/binaryservice.thrift
@@ -0,0 +1,6 @@
+namespace java thrift.test
+
+// this service will blow up during compile unless "binary" types work.
+service BinaryService {
+ binary fetchBlob(1: i64 id)
+}

0 comments on commit 5e0a498

Please sign in to comment.