Permalink
Commits on Apr 27, 2016
  1. @cacoco

    Twitter OSS: Prepare libraries for next release

    Problem
    
    We're releasing the next versions of the Twitter OSS libraries:
    util - 6.34.0
    ostrich - 9.18.0
    scrooge - 4.7.0
    finagle - 6.35.0
    twitter-server - 1.20.0
    finatra - 2.1.6
    
    Solution
    
    Update to the release version.
    
    RB_ID=826660
    cacoco committed with jenkins Apr 27, 2016
  2. @mosesn

    scrooge-generator: Adds regex parsers to generator

    RB_ID=826249
    mosesn committed with jenkins Apr 26, 2016
Commits on Apr 21, 2016
  1. @cacoco

    finagle/finatra/scrooge/twitter-server: bin/travisci updates and fixes

    Problem
    
    The order of building needs to be updated for twitter-server and scrooge
    as building finagle should now happen after building the scrooge-sbt-plugin.
    The finagle/finatra builds are complaining about not finding the 2.10 version of
    the scrooge-generator.
    
    Solution
    
    Update the order of building in twitter-server and scrooge scripts.
    Specifically, publish the scrooge-generator for 2.10 in the finagle
    script.
    
    RB_ID=824936
    TBR=true
    cacoco committed with jenkins Apr 21, 2016
  2. @cacoco

    finagle/finatra/scrooge/twitter-server: Update travisci scripts for s…

    …crooge-sbt-plugin
    
    Problem
    
    The TravisCI build is currently in error for listed projects as the 2.10
    SNAPSHOT version of the scrooge-sbt-plugin is not being published locally
    for the downstream dependencies.
    
    Solution
    
    Ensure the scala 2.10 SNAPSHOT version of the scrooge-sbt-plugin is
    published locally for downstream projects to pick up.
    
    RB_ID=824864
    cacoco committed with jenkins Apr 21, 2016
Commits on Apr 20, 2016
  1. @cacoco

    finatra/finagle/twitter-server/scrooge - Update travisci scripts

    Problem
    
    A recent update to scrooge's project/Build.scala means that the
    scrooge-sbt-plugin needs to be explicitly published locally for
    downstream use.
    
    Solution
    
    Update the listed projects' bin/travisci to ensure that the
    scrooge-sbt-plugin target is published locally for downstream
    dependencies.
    
    Result
    
    Happy TravisCI builds!
    
    RB_ID=824504
    cacoco committed with jenkins Apr 20, 2016
  2. @mosesn

    scrooge-generator: No more dep on util

    Problem
    
    We can't depend on util anymore because scrooge-generator must be
    able to output java7 compatible output for scala 2.10.
    
    Solution
    
    Remove dependency on util
    
    RB_ID=822896
    TBR=true
    mosesn committed with jenkins Apr 19, 2016
Commits on Apr 19, 2016
  1. @kevinoliver

    finagle/finatra/scrooge: Really fix sbt builds

    Problem
    
    The sbt builds were still failing even after yesterday's changes.
    
    Solution
    
    Fix them harder.
    
    RB_ID=821864
    kevinoliver committed with jenkins Apr 14, 2016
  2. upgrade commons-cli to 1.3.1

    RB_ID=821312
    Matt Landis committed with jenkins Apr 12, 2016
  3. @kevinoliver

    finagle: Fix sbt build

    Problem
    
    Finagle is not using the correct version of the scrooge-sbt-plugin.
    
    Solution
    
    Use the current version, 4.6.0, when building on master.
    Use version 4.6.0-SNAPSHOT if building on any other branch.
    
    RB_ID=821061
    kevinoliver committed with jenkins Apr 12, 2016
Commits on Apr 11, 2016
  1. @shshe

    Problem

    For an enum, generated case objects have an abstract name and value
    field, but not originalName.
    
    Solution
    
    Add originalName to the ThriftEnum trait and generated EnumUnknown
    case classes.
    
    This is commit 2 of 2 and changes scrooge-core.
    
    Signed-off-by: Kevin Oliver <koliver@twitter.com>
    
    RB_ID=820075
    shshe committed with jenkins Apr 11, 2016
  2. @jcrossley

    scrooge: Add deserialization context on generated Java Thrift clients

    Problem
    
    In order to do response classification for Java thrift clients, the request
    deserialization context must be set in the client.
    
    Solution
    
    Set the deserialization context on generated Java Thrift clients.
    
    RB_ID=812492
    jcrossley committed with jenkins Apr 7, 2016
  3. @shshe

    scrooge: Add originalName to ThriftEnum

    Problem
    
    For an enum, generated case objects have an abstract name and value
    field, but not originalName.
    
    Solution
    
    Add originalName to the ThriftEnum trait and generated EnumUnknown
    case classes. Add default implementation of originalName to return
    name to avoid breaking the API.
    
    This is commit 1 of 2. Part 2 will add the changes to ThriftEnum in
    scrooge-core.
    
    Signed-off-by: Kevin Oliver <koliver@twitter.com>
    
    RB_ID=814147
    shshe committed with jenkins Apr 5, 2016
Commits on Mar 29, 2016
  1. source: fix more unused imports for scala 2.11.8

    RB_ID=815287
    Matt Landis committed with jenkins Mar 29, 2016
Commits on Mar 21, 2016
  1. @mosesn

    scrooge: Add scrooge-generator back to serializer in sbt

    Problem
    
    Travis says it can't find the main method for scrooge serializer
    
    Solution
    
    Add the main method back in!  I removed it when trying to clean up
    the scrooge/project/Build.scala and didn't notice that it broke the
    OSS build.
    
    Result
    
    Fixes the scrooge travis build
    
    RB_ID=810856
    mosesn committed with jenkins Mar 19, 2016
  2. @mosesn

    scrooge-docs: Modernize the scrooge README

    Problem
    
    The scrooge docs are out of date
    
    Solution
    
    Update them
    
    RB_ID=810712
    mosesn committed with jenkins Mar 19, 2016
  3. @mosesn

    twitter-server,scrooge: Skip flaky tests

    Problem
    
    Our TwitterServer OSS build is not doing so hot because of a flaky
    test.
    
    Solution
    
    Make sure OSS TwitterServer (and scrooge, while we're at it) doesn't
    run flaky tests
    
    Result
    
    TwitterServer build is fixed!
    
    RB_ID=810870
    mosesn committed with jenkins Mar 19, 2016
Commits on Mar 14, 2016
  1. @olix0r

    scrooge: Update sbt-dependency-graph plugin to 0.8.2

    Problem
    
    sbt-dependency-graph has been updated, supporting additional features
    
    Solution
    
    Upgrade it.
    
    Signed-off-by: Kevin Oliver <koliver@twitter.com>
    
    RB_ID=810358
    olix0r committed with jenkins Mar 14, 2016
Commits on Mar 11, 2016
  1. @cacoco

    scrooge-maven-plugin: Fix missing dependency

    Problem
    
    The plugin formerly inherited a dependency transitively.
    
    Solution
    
    Add the dependency explicitly.
    
    Result
    
    Buildable and deployable plugin.
    
    RB_ID=809806
    TBR=true
    cacoco committed with jenkins Mar 11, 2016
Commits on Mar 10, 2016
  1. @cacoco

    Bump versions - util/ostrich/finagle/scrooge/twitter-server

    Prepare libraries for release.
    
    RB_ID=809587
    cacoco committed with jenkins Mar 10, 2016
  2. @vkostyukov

    scrooge: Safe toString versions for Types

    Problem
    
    Scrooge dumps an entire type structure as a string in case of exceptions.
    Sometimes that causes allocating quite a big strings thereby OOMs.
    
    Solution
    
    Print only wrapping types, not the underlying structure when converted to
    string.
    
    RB_ID=804231
    vkostyukov committed with jenkins Mar 10, 2016
  3. @kevinoliver

    Add PULL_REQUEST_TEMPLATEs

    Problem
    
    We want to make it as easy as possible for our contributors to do the
    right thing.
    
    Solution
    
    Use Github's PR templates[1] to help them do this.
    
    Result
    
    Pull requests are more likely to be formatted correctly.
    
    [1] https://help.github.com/articles/creating-a-pull-request-template-for-your-repository/
    
    RB_ID=808946
    kevinoliver committed with jenkins Mar 10, 2016
  4. @jcrossley

    scrooge: Update spec to use c.t.f.Address in Name.bound

    Problem
    
    Name.bound now takes c.t.f.Address instead of SocketAddress; ServiceGeneratorSpec wasn't updated
    
    Solution
    
    Update ServiceGeneratorSpec
    
    RB_ID=808744
    jcrossley committed with jenkins Mar 10, 2016
  5. @mosesn

    scrooge-generator-tests: Rename internal resources

    Problem
    
    Forgot to rename some resources which broke tests.
    
    Solution
    
    ag -l 'scrooge-generator/src' ./scrooge/scrooge-generator-tests | \
      xargs sed -i '' 's/scrooge-generator\/src/scrooge-generator-tests\/src/'
    
    RB_ID=808250
    mosesn committed with jenkins Mar 9, 2016
  6. @mosesn

    scrooge-generator: experimental-java RIP

    Problem
    
    experimental-java doesn't work, and when we broke it even further
    by deleting scrooge-runtime, nobody noticed.  Let's delete it, since
    we don't currently have plans to make it great again.
    
    Solution
    
    Baleet it.
    
    RB_ID=808294
    mosesn committed with jenkins Mar 8, 2016
Commits on Mar 7, 2016
  1. @cacoco

    scrooge: Remove scroogeRuntime dependency from Build.scala

    Problem
    
    scrooge-runtime has been retired and the Build.scala should
    no longer reference it.
    
    Result
    
    Buildable scrooge project.
    
    RB_ID=807618
    TBR=true
    cacoco committed with jenkins Mar 5, 2016
  2. @cacoco

    scrooge - Remove scrooge-runtime dependency

    Problem
    
    scrooge-runtime has been retired and should no longer
    be referenced in the scrooge Build.scala file.
    
    Resolution
    
    Remove the reference.
    
    Result
    
    A correct build file which allows scrooge to correctly
    build.
    
    RB_ID=807542
    TBR=true
    cacoco committed with jenkins Mar 5, 2016
  3. @mosesn

    scrooge-ostrich: Removed scrooge-ostrich from scrooge

    Problem
    
    scrooge-ostrich is a bummmmmmer
    
    Solution
    
    Remove it!
    
    RB_ID=806300
    mosesn committed with jenkins Mar 3, 2016
  4. @mosesn

    scrooge-generator: moved tests and simplified dependencies

    Problem
    
    scrooge-generator has a test dependency on finagle, which complicates
    publishing, since we publish with sbt, which must be able to compile
    to publish, and cannot compile without pulling down test dependencies.
    
    Solution
    
    Split up the scrooge-generator tests from the library.
    
    RB_ID=805455
    mosesn committed with jenkins Mar 3, 2016
  5. @mosesn

    scrooge-runtime: RIP

    Problem
    
    scrooge has unnecessary dependencies on finagle.  scrooge-runtime
    is very deprecated, it's time to delete it.
    
    Solution
    
    baleet
    
    RB_ID=805510
    TBR=true
    mosesn committed with jenkins Mar 2, 2016
  6. @mosesn

    scrooge-ostrich: deprecate me cap'n

    Problem
    
    We don't want people to use scrooge-ostrich anymore.
    
    Solution
    
    Let's mark it as deprecated today, and start moving people off of
    it.
    
    RB_ID=805521
    mosesn committed with jenkins Mar 2, 2016
Commits on Feb 29, 2016
  1. @mosesn

    scrooge-generator: Fix the sbt build

    RB_ID=804026
    mosesn committed with jenkins Feb 25, 2016
Commits on Feb 25, 2016
  1. @mosesn

    scrooge-generator: Remove finagle dependency

    Problem
    
    scrooge-generator has a spurious dependency on finagle.
    
    Solution
    
    Remove the dependency on finagle, and go back to the non-LoadService
    [glory days][0]
    
    [0]: 080c88f
    
    RB_ID=803188
    mosesn committed with jenkins Feb 24, 2016
Commits on Feb 8, 2016
  1. @kevinoliver

    scrooge-generator: Handle exceptions thrown in decodeResponse

    Motivation
    
    When an exception is thrown in
    `ServiceName$FinagleClient.decodeResponse` it is not seen by the
    `ResponseClassifier`.
    
    Solution
    
    Wrap the `decodeResponse` call in `Try.apply` and adjust the logic to
    handle that.
    
    Result
    
    Clients can now properly classify these exceptions.
    
    RB_ID=796974
    kevinoliver committed with jenkins Feb 5, 2016
Commits on Feb 4, 2016
  1. @cacoco

    release: Prepare libraries for OSS release

    RB_ID=796660
    cacoco committed with jenkins Feb 4, 2016
  2. @ryanoneill

    util, finagle, scrooge: Add ryano to More Owners Files

    RB_ID=796566
    ryanoneill committed with jenkins Feb 3, 2016