Client won't throw exception on void function #17

merged 2 commits into from Mar 18, 2013


None yet

5 participants

bancek commented Nov 5, 2012

If you have void function in your service that throws an exception, client will always silently result with unit (Future.Done).


Any thoughts on this @chunyan ?

leepa commented Feb 19, 2013

Any chance this can move forwards? This causes problems for things like cassandra.thrift, for example.

+1 on moving this forward

chunyan commented Mar 18, 2013

My apologies. Scrooge had been short staffed, and we didn't stay on top of all things on Github. I will go through all pull requests and issues this week.

@chunyan chunyan commented on the diff Mar 18, 2013
@@ -239,6 +239,17 @@ class ServiceGeneratorSpec extends SpecificationWithJUnit with EvalHelper with J
client.deliver("Boston")() mustEqual 42
+ "success void" in {
+ val request = encodeRequest("remove", ExceptionalService.RemoveArgs(123))
chunyan Mar 18, 2013 Contributor

We have changed the naming of internal marshalling functions for args and result. So please use remove$args and remove$result instead of RemoveArgs and RemoveResult.

Everything else looks good.

@chunyan chunyan closed this Mar 18, 2013
@chunyan chunyan reopened this Mar 18, 2013
@chunyan chunyan merged commit 4855f16 into twitter:master Mar 18, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment