Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finagle Deps are way behind the mainline. #354

Open
jho opened this issue Aug 13, 2018 · 3 comments
Open

Finagle Deps are way behind the mainline. #354

jho opened this issue Aug 13, 2018 · 3 comments

Comments

@jho
Copy link

jho commented Aug 13, 2018

We use storehaus in a bunch of places in our infrastructure. I hate to say it but we really regret the decision now since storehaus is so far behind on it's Finagle deps. Is upgrading them a possibility? I'd be willing to contribute in someway if its deemed plausible.

@johnynek
Copy link
Collaborator

Are you hitting any binary compatibility problems? You should be able to work with a later version of finagle.

We (at stripe) use storehaus with much later finagle versions without a problem, but fixing to the very latest often causes problems for users (since the APIs we touch often don't change much).

That said updating to alleviate issues should be fine.

PRs happily accepted!

@jho
Copy link
Author

jho commented Sep 27, 2018

@johnynek Thanks for the reply! We did encoutner binary compat problems, but I wonder now if they were because of mixed finagle versions from our own diamond dependency problems. We will try upgrading more carefully and get back to you. What versions of finagle does stripe use against the latest storehaus? Thanks again for the reply! Wanted to also thank you for all the work you've done on Storehaus, Summingbird, Bijection, etc. Good stuff.

@cacts
Copy link

cacts commented Dec 12, 2019

Opened #361 that updates Finagle et al to much more recent versions, the old version of netty required by older finagles was particularly problematic in other projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants