Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Nil exception happening after connection is open for a while #42

Open
ianloblaw opened this Issue · 1 comment

2 participants

@ianloblaw

Hello,

Recently I was trying to run version 0.8.2 to connect to scribe, after a few hours I noticed that the connection dies (seemingly on the ruby end) and results in the following exception

undefined method write' for nil:NilClass
ruby/1.9.1/gems/thrift_client-0.8.2/lib/thrift_client/server.rb:82:in
write'
ruby/1.9.1/gems/thrift-0.8.0/lib/thrift/protocol/binary_protocol.rb:91:in write_i16'
ruby/1.9.1/gems/thrift-0.8.0/lib/thrift/protocol/binary_protocol.rb:43:in
write_message_begin'
ruby/1.9.1/gems/thrift-0.8.0/lib/thrift/client.rb:29:in `send_message'

This seems to be related to line 60 of server.rb

return nil unless @connection

Unfortunately I haven't figured out why the connection is becoming nil, but it seems to be internal to the gem.

I am not sure if the closing of the connection is expected behavior or not, but I think anyone can agree that exception's relating to calls on nil aren't a sensible way dealing with an error case.

@kbrock

I'm seeing this too.
Am running jruby, which may be a culpret as well

@ianloblaw are you still seeing this? did you do anything in particular to safeguard/fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.