New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why are JS files ignored in the Bower package? #171

Closed
Rudloff opened this Issue Sep 4, 2016 · 5 comments

Comments

Projects
None yet
2 participants
@Rudloff
Contributor

Rudloff commented Sep 4, 2016

Hello,

Since 590d7a3, twemoji.js is excluded from the Bower package. As I use Bower in order to easily get JS libraries, this breaks my workflow.
Is there any particular reason these files are ignored?

@Rudloff Rudloff referenced this issue in Rudloff/emoji-everywhere Sep 4, 2016

Closed

Some Emojis not rendered, show as numeric block. #4

@WebReflection

This comment has been minimized.

Show comment
Hide comment
@WebReflection

WebReflection Sep 5, 2016

Collaborator

files seem to be there, which change broke your build? I might double check later on (this evening)

Apologies for any inconvenience

Collaborator

WebReflection commented Sep 5, 2016

files seem to be there, which change broke your build? I might double check later on (this evening)

Apologies for any inconvenience

@Rudloff

This comment has been minimized.

Show comment
Hide comment
@Rudloff

Rudloff Sep 5, 2016

Contributor

It seems the files were meant to be ignored since 9edd9dd but the syntax was wrong so 590d7a3 fixed it.
Having these files in the ignore property means Bower removes them after install (but it still downloads them).
The same thing applies to the images (16x16, etc) folders.

Contributor

Rudloff commented Sep 5, 2016

It seems the files were meant to be ignored since 9edd9dd but the syntax was wrong so 590d7a3 fixed it.
Having these files in the ignore property means Bower removes them after install (but it still downloads them).
The same thing applies to the images (16x16, etc) folders.

@WebReflection

This comment has been minimized.

Show comment
Hide comment
@WebReflection

WebReflection Sep 5, 2016

Collaborator

would ignoring everything but version 2 be OK? the main file is version 2 and bringing in all V1 assets is pointless, right?

Collaborator

WebReflection commented Sep 5, 2016

would ignoring everything but version 2 be OK? the main file is version 2 and bringing in all V1 assets is pointless, right?

@Rudloff

This comment has been minimized.

Show comment
Hide comment
@Rudloff

Rudloff Sep 5, 2016

Contributor

Yes, it would be OK for me.

Contributor

Rudloff commented Sep 5, 2016

Yes, it would be OK for me.

@WebReflection

This comment has been minimized.

Show comment
Hide comment
@WebReflection

WebReflection Sep 5, 2016

Collaborator

I will try to make it work this evening (I don't use/know bower that much so a PR would also be welcome)

Collaborator

WebReflection commented Sep 5, 2016

I will try to make it work this evening (I don't use/know bower that much so a PR would also be welcome)

Rudloff added a commit to Rudloff/twemoji that referenced this issue Sep 5, 2016

Rudloff added a commit to Rudloff/twemoji that referenced this issue Sep 5, 2016

Rudloff added a commit to Rudloff/twemoji that referenced this issue Sep 5, 2016

WebReflection added a commit that referenced this issue Sep 5, 2016

Merge pull request #172 from Rudloff/feature/bower
Don't ignore V2 files in bower.json (fixes #171)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment