Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why are JS files ignored in the Bower package? #171

Closed
Rudloff opened this issue Sep 4, 2016 · 5 comments
Closed

Why are JS files ignored in the Bower package? #171

Rudloff opened this issue Sep 4, 2016 · 5 comments

Comments

@Rudloff
Copy link
Contributor

@Rudloff Rudloff commented Sep 4, 2016

Hello,

Since 590d7a3, twemoji.js is excluded from the Bower package. As I use Bower in order to easily get JS libraries, this breaks my workflow.
Is there any particular reason these files are ignored?

@WebReflection
Copy link
Collaborator

@WebReflection WebReflection commented Sep 5, 2016

files seem to be there, which change broke your build? I might double check later on (this evening)

Apologies for any inconvenience

@Rudloff
Copy link
Contributor Author

@Rudloff Rudloff commented Sep 5, 2016

It seems the files were meant to be ignored since 9edd9dd but the syntax was wrong so 590d7a3 fixed it.
Having these files in the ignore property means Bower removes them after install (but it still downloads them).
The same thing applies to the images (16x16, etc) folders.

@WebReflection
Copy link
Collaborator

@WebReflection WebReflection commented Sep 5, 2016

would ignoring everything but version 2 be OK? the main file is version 2 and bringing in all V1 assets is pointless, right?

@Rudloff
Copy link
Contributor Author

@Rudloff Rudloff commented Sep 5, 2016

Yes, it would be OK for me.

@WebReflection
Copy link
Collaborator

@WebReflection WebReflection commented Sep 5, 2016

I will try to make it work this evening (I don't use/know bower that much so a PR would also be welcome)

Rudloff added a commit to Rudloff/twemoji that referenced this issue Sep 5, 2016
Rudloff added a commit to Rudloff/twemoji that referenced this issue Sep 5, 2016
Rudloff added a commit to Rudloff/twemoji that referenced this issue Sep 5, 2016
WebReflection added a commit that referenced this issue Sep 5, 2016
Don't ignore V2 files in bower.json (fixes #171)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.