Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganization and cleanup of README.md #364

Merged
merged 3 commits into from Jul 10, 2019
Merged

Reorganization and cleanup of README.md #364

merged 3 commits into from Jul 10, 2019

Conversation

@alanbato
Copy link
Contributor

alanbato commented Jun 28, 2019

As part of the changes proposed in #361 and #362, we should trim down our README to only include what's relevant to the current version, and also update our contributing guidelines to reflect the updated development workflow.

As I'm not the most familiar with Twemoji's API details, any and all comments are welcome :)

Also, all these Markdown files are now Markdownlint compliant.

@alanbato alanbato requested a review from n8downs Jun 28, 2019
@alanbato alanbato changed the title [WIP] Reorganization and cleanup of README.md Reorganization and cleanup of README.md Jul 9, 2019
@n8downs n8downs changed the base branch from gh-pages to master Jul 10, 2019
Copy link
Contributor

n8downs left a comment

Thanks for cleaning up the docs!

messages. Use git's [interactive rebase](https://help.github.com/en/articles/about-git-rebase)
feature to tidy up your commits before making them public.

3. Locally merge (or rebase) the upstream development branch into your topic branch:
2. Run `yarn prepublish`. This will do several things:

This comment has been minimized.

Copy link
@n8downs

n8downs Jul 10, 2019

Contributor

I believe this should be prepublishOnly


To properly support emoji, the document character set must be set to UTF-8. This can done by including the following meta tag in the document `<head>`

```html
<meta charset="utf-8">
```

#### Exclude Characters (V1)
### Exclude Characters (V1)

This comment has been minimized.

Copy link
@n8downs

n8downs Jul 10, 2019

Contributor

Still V1?

@CLAassistant

This comment has been minimized.

Copy link

CLAassistant commented Jul 10, 2019

CLA assistant check
All committers have signed the CLA.

@n8downs n8downs merged commit 0bff51c into master Jul 10, 2019
1 check passed
1 check passed
license/cla Contributor License Agreement is signed.
Details
@n8downs n8downs deleted the new_readme branch Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.