Fix DateTimeFormatter.timezone for negative UTC offset #6

Merged
merged 2 commits into from Aug 30, 2012

Conversation

Projects
None yet
3 participants
Contributor

KL-7 commented Aug 30, 2012

Fixes #4. The problem was with timezones that have negative UTC offset, e.g., UTC+3.

I also removed space from full time zone format, because it's seems like this space is usually omitted (correct me if I'm wrong or it's a part of some standard). Now it looks like "UTC±07:00".

This pull request passes (merged 2d8771e into 07f4568).

Contributor

KL-7 commented Aug 30, 2012

Btw, @cameron, do you mind switching from tabs to two spaces indention in CoffeeScript files?

Collaborator

camertron commented Aug 30, 2012

Ah ok, that explains why that was failing for you and not for me :) Travis must also run in a region that doesn't have a negative offset. Very interesting, thanks for looking into it. And YES we should definitely switch from tabs to spaces. I don't know why I didn't do that from the beginning.

camertron merged commit 5ace5ce into twitter:master Aug 30, 2012

camertron referenced this pull request Aug 30, 2012

Closed

JS specs still failing #4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment