Add '# encoding: UTF-8' to all Ruby files. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heh, beat me to it. I've been working on some other stuff at the same time as the magic comments :) Accept this one, not mine! |
camertron
added a commit
that referenced
this pull request
Apr 2, 2012
Add '# encoding: UTF-8' to all Ruby files to fix encoding issues with Ruby 1.9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the same issue as #4, but with a fewer commits =)
I think you can merge it as an initial solution for encoding problems on 1.9. Afaik 1.8 simply ignores magic comments so it shouldn't cause any problems for this Ruby version. You can add some special logic for 1.8 involving
$KCODElater if you think that's necessary.