Fix rcov rake task, add rcov:full. Mark Bidi specs as slow. #83

Merged
merged 4 commits into from Nov 14, 2012

Projects

None yet

3 participants

@KL-7
Collaborator
KL-7 commented Nov 12, 2012

Everything is in the title, but anyway:

  1. Mark Bidi specs as slow as they really take quite a long time to run. Not sure whether a shorter (and therefore faster) version of this test is necessary, so I'll leave it up to you, @camertron.
  2. Fix spec:rcov rake task by adding require 'rspec/autorun' to spec_helper.rb. Without it rcov for some reason ignores all the specs. There was a similar issue reported, but I didn't look into the details since this simple require seems to fix everything.
  3. Add spec:rcov:full to check coverage against the whole test suit including super long-running specs for normalization, collation, Bidi, etc.

As I mentioned on Twitter, rcov runs only on 1.8.7 and the full TwitterCLDR's test suit runs far too long on it. I think we've discussed that before, @camertron, but I don't remember what we've decided. If there're no any downsides of switching to simplecov I can look into it. It must be quite easy to switch and with it we'll have coverage tool on 1.9 where tests are running noticeably faster.

@camertron
Collaborator

Looks good! I have marked the Bidi specs as :slow in another PR as well - great minds think alike :) Glad we have the rcov stuff working too, but like you said it's probably better to upgrade to simplecov as soon as possible. With all the recent PRs and good work being done by you and @tanin47, I think we're about ready to launch twitter-cldr v2.0. Do you think you can convert us over to simplecov in the not so distant future, @KL-7?

@KL-7
Collaborator
KL-7 commented Nov 13, 2012

Hey, @camertron. I've added SimpleCov rake tasks for MRI 1.9. Now rake spec:cov[:full] runs specs with corresponding coverage tool (rcov or simplecov) both on 1.8 and 1.9. You definitely want to use the latter (as it's much faster), but I don't see any reason to remove rcov, so I left it as well.

Btw, TwitterCLDR started running into an issue on Travis CI – full test suit on 1.8.7 sometimes exceeds 25 minutes limit that they give for a build to run. Probably we'll have to disable some long-running specs on Travis CI when testing against 1.8.7 or find some other solution to this problem, e.g., make some of the specs faster ;)

@KL-7
Collaborator
KL-7 commented Nov 13, 2012

Btw, test coverage percent is 96.93% without "slow" specs and 98.72% with them. Pretty cool I think.

@tanin47
tanin47 commented Nov 14, 2012

98.72% That is awesome!!

@camertron
Collaborator

Wow that is awesome! Ok, let's merge this puppy :)

@camertron camertron merged commit 22a1910 into twitter:master Nov 14, 2012

1 check passed

Details default The Travis build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment