Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Dual form for time measurement. #90

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants

yarons commented Dec 13, 2012

Fixed dual form, I'm still in doubt about certain terms.
In Hebrew there are words for the day after tomorrow and the day before yesterday (מחרתיים/שלשום accordingly).

I can't find a way to blend them in, furthermore, I can't find a place to add these words whatsoever.

Dual form for time measurement.
Fixed dual form, I'm still in doubt about certain terms.
In Hebrew there are words for the day after tomorrow and the day before yesterday (מחרתיים/שלשום accordingly).

I can't find a way to blend them in, furthermore, I can't find a place to add this words whatsoever.

amire80 commented Dec 13, 2012

The strings are correct.

Collaborator

camertron commented Dec 13, 2012

Hmm interesting, @yarons. The sections hour-future and hour-past should be the right places to add relative timespan information. As I recall, CLDR specifically defines "day after tomorrow" and "day before yesterday" strings, but TwitterCLDR doesn't support them (yet). Also, what's the reasoning for removing the {0} part of the strings you changed? Finally, these changes should be in resources/custom/locales/he/units.yml - see my comment for pull request #88 for an explanation.

Collaborator

camertron commented Jan 6, 2014

No activity for about a year, closing.

@camertron camertron closed this Jan 6, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment