Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upXCode 10 GM and Swift 4.2 Compiler Warning #95
Comments
This comment has been minimized.
This comment has been minimized.
AlexGingell
commented
Sep 15, 2018
•
|
Has anyone managed to obtain a version of TwitterKit v3.4.0 that is error free? I have checked many forks and branches and cannot see any versions which compile and run error-free / produce no issues. If it is not this private submodule problem it is
|
This comment has been minimized.
This comment has been minimized.
JacobJT
commented
Sep 26, 2018
|
I don't have any experience working with frameworks or I'd make my own PR, but I wouldn't even know how to confirm it works or not, Any chance we can get implementations to fix this error (and subsequent TWTRColor.h issue) similar to these commits from one of the forks? Remove the private module: Add TWTRColor.h to the public module map: Dunno if this one is required, but was done right after the others, unlink libTwitterCore in TwitterKit.framework: Been lookin' forward to the day we have a warning free project to compile for years, and this is one of the last couple things preventing that. |
This comment has been minimized.
This comment has been minimized.
jlaws
commented
Sep 27, 2018
•
|
Posted on the twitter dev forum here and posted a request to @twitterdev on Twitter here. |
This comment has been minimized.
This comment has been minimized.
jlaws
commented
Oct 9, 2018
|
I removed the Twitter SDK from my cocoapods and no longer have this issue |
jlaws
closed this
Oct 20, 2018
This comment has been minimized.
This comment has been minimized.
npu3pak
commented
Nov 28, 2018
|
Got some working solution. It fixed all TwitterCore related warnings for me. |
jlaws commentedSep 13, 2018
Building the TwitterCore cocoapod shows compiler warnings.
Expected behavior
The cocoapod should build with no warnings.
Actual behavior
Steps to reproduce the behavior