New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XCode 10 GM and Swift 4.2 Compiler Warning #95

Closed
jlaws opened this Issue Sep 13, 2018 · 5 comments

Comments

Projects
None yet
4 participants
@jlaws

jlaws commented Sep 13, 2018

Building the TwitterCore cocoapod shows compiler warnings.

Expected behavior

The cocoapod should build with no warnings.

Actual behavior

/Users/joelaws/Workspace/kratos/Pods/TwitterCore/iOS/TwitterCore.framework/Modules/module.private.modulemap:1:29: Private submodule 'TwitterCore.Private' in private module map, expected top-level module
/Users/joelaws/Workspace/kratos/Pods/TwitterCore/iOS/TwitterCore.framework/Modules/module.private.modulemap:1:29: Rename 'TwitterCore.Private' to ensure it can be found by name

Steps to reproduce the behavior

  1. Download XCode 10 GM
  2. Setup a project and Podfile that depends on TwitterCore
  3. Compile the main target and the TwitterCore cocoapod
  4. see the build warnings
@AlexGingell

This comment has been minimized.

AlexGingell commented Sep 15, 2018

Has anyone managed to obtain a version of TwitterKit v3.4.0 that is error free? I have checked many forks and branches and cannot see any versions which compile and run error-free / produce no issues. If it is not this private submodule problem it is

Umbrella header for module 'TwitterCore' does not include header 'TWTRColorUtil.h'

@JacobJT

This comment has been minimized.

JacobJT commented Sep 26, 2018

@rajul-arora @evansobkowicz

I don't have any experience working with frameworks or I'd make my own PR, but I wouldn't even know how to confirm it works or not,

Any chance we can get implementations to fix this error (and subsequent TWTRColor.h issue) similar to these commits from one of the forks?

Remove the private module:
cb75d55

Add TWTRColor.h to the public module map:
dc4b422

Dunno if this one is required, but was done right after the others, unlink libTwitterCore in TwitterKit.framework:
de5674f

Been lookin' forward to the day we have a warning free project to compile for years, and this is one of the last couple things preventing that.

@jlaws

This comment has been minimized.

jlaws commented Sep 27, 2018

Posted on the twitter dev forum here and posted a request to @twitterdev on Twitter here.

@jlaws

This comment has been minimized.

jlaws commented Oct 9, 2018

I removed the Twitter SDK from my cocoapods and no longer have this issue

https://blog.twitter.com/developer/en_us/topics/tools/2018/discontinuing-support-for-twitter-kit-sdk.html

@jlaws jlaws closed this Oct 20, 2018

@npu3pak

This comment has been minimized.

npu3pak commented Nov 28, 2018

Got some working solution. It fixed all TwitterCore related warnings for me.
https://gist.github.com/npu3pak/108d8332a774289c08472d6fd85a1bbb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment